Inline suggestion is read twice by the screen reader

[meganrogge]

reported by @jooyoungseo

1. trigger an inline suggestion
2. 🐛 it is read twice

[meganrogge]

@hediet maybe related to b7df1f8?

[Minhyung-Lee]

I was able to reproduce this issue where the screen reader announces the ARIA-live autocomplete inline suggestion twice after announcing the typed letter.
I noticed something when I tried typing out various other libraries. The second announcement repeated the previously suggested ARIA announcement after the current one, instead of the current one twice. (Due to the nature of the bug, it might have gone unnoticed and understood as the ARIA-live announcing twice, since we were mainly looking at the "pandas" library in the meeting.)
This could create confusion for users when they are relying on TAB to autocomplete suggestions, since after pressing TAB, there is no confirmation of which of the two suggestions was chosen.
I experienced this on my laptop running Windows 11 with JAWS and wanted to share this information in case it might be helpful in resolving this bug.

Settings altered from the original VS Code Insiders build:

• The "Editor: Screen Reader Announce Inline Suggestion" setting is enabled.
• Under "Editor: Quick Suggestions," the Value of the Item "other" is switched from "on" to "inline."

[meganrogge]

@jooyoungseo has reported that this is no longer reproducing. However, there's a long delay between the audio cue and the inline suggestion being read - to the extent that he has turned it off.

This is because the audio cue takes some time to load. Is there anything we can do about this @hediet ?

vscode/src/vs/editor/contrib/inlineCompletions/browser/ghostTextWidget.ts

Lines 161 to 170 in a0ff19a

	if (notifyUser) {
	this.audioCueService.playAudioCue(AudioCue.inlineSuggestion).then(() => {
	if (this.editor.getOption(EditorOption.screenReaderAnnounceInlineSuggestion)) {
	const lineText = this.editor.getModel()?.getLineContent(ghostText.lineNumber);
	if (lineText) {
	alert(ghostText.renderForScreenReader(lineText));
	}
	}
	});
	}

[meganrogge]

this reproduces when the audio cue plays.

@jooyoungseo has disabled it because of the delay. @hediet is there anything we can do to play the audio cue immediately or is that impossible because it needs to be loaded every time?

[hediet]

is there anything we can do to play the audio cue immediately or is that impossible because it needs to be loaded every time?

It should be cached, so loading it a second time should be faster.

[meganrogge]

@jooyoungseo could you pls let us know if this is now working as expected - even when you enable the audio cue?

[jooyoungseo]

@meganrogge -- I have confirmed that this issue was resolved in today's insiders. Also, the delay issue has been addressed! Many thanks.