Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous run for ONLY selected tests #178973

Closed
matepek opened this issue Apr 3, 2023 · 4 comments
Closed

Continuous run for ONLY selected tests #178973

matepek opened this issue Apr 3, 2023 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@matepek
Copy link

matepek commented Apr 3, 2023

Currently all the explored tests are rerun when one of them are changed.
My users would like to run a set of tests only sometime. Currently there are o option for that.
There is a plan for adding that to the UI.
Would be great to see that feature soon. Thanks.

(First maybe just the filtering could work. That's probably smaller change, then an advanced UI with advanced configuration would be the final solution.)

@connor4312 connor4312 added feature-request Request for new features or functionality testing Built-in testing support labels Apr 3, 2023
@connor4312 connor4312 added this to the On Deck milestone Apr 3, 2023
@connor4312
Copy link
Member

connor4312 commented Apr 4, 2023

First pass:

Kapture.2023-04-04.at.16.15.13.mp4

This will be in the next Insiders. Open questions:

  1. Something I'm not sure about is pinning watched tests to the top. It's kind of handy to see the "working set", but also having it jump around may be disruptive.
  2. Currently it only continuously run the "run" profiles, eventually we probably want debug profiles. We'd want to make sure we avoid auto-opening the debug view and console in this scenario.
  3. Currently it uses (only) the default selected profiles. Would any users want a different continuous profile than the one they've selected to run tests?

@connor4312
Copy link
Member

Closing this to mark as done. Please let me know if anyone has additional feedback.

@connor4312
Copy link
Member

You can verify at an API or UI level starting with the selfhost test provider.

Verify continuous runs are requested and cancelled as you enable and disable continuous test running for specific tests in the vscode repo. If continuous test run is enabled for its tests, the icon should be always show and the test should be pinned as in my demo video above. Continuous test run cannot be toggled for subtests of a parent test.

@connor4312 connor4312 added the verification-needed Verification of issue is requested label Apr 25, 2023
@roblourens roblourens added the verified Verification succeeded label Apr 26, 2023
@roblourens
Copy link
Member

  1. I think I'm not a fan of the fact that setting the top level test file to continuous run pins it to the top and shows the 👁️ but if I do that on a child item and collapse the parent, it is not pinned to the top and there is no way to tell that there is another continuous run item there. It feels inconsistent to be setting aside some 👁️ items, but only some of them.
  2. That should be easy with the extra options I added for Jupyter Run By Line, if you add debugging

@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality testing Built-in testing support verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants