Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet XHTML broken #18434

Closed
Avol-V opened this issue Jan 12, 2017 · 2 comments
Closed

Emmet XHTML broken #18434

Avol-V opened this issue Jan 12, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone

Comments

@Avol-V
Copy link

Avol-V commented Jan 12, 2017

  • VSCode Version: 1.8.1
  • OS Version: Ubuntu 14.04

Steps to Reproduce:

  1. Set xhtml syntax:
    	"emmet.syntaxProfiles": {
    		"html": "xhtml"
    	},
  2. Write br and press Tab.

Result is:

<br></br>

Should be:

<br />

Same for other tags.

Also didn't work shorthands like input:radio, result is:

<input:radio></input:radio>
@mjbvz mjbvz added the emmet Emmet related issues label Jan 12, 2017
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jan 17, 2017

@Avol-V For the time being, please use the below

"emmet.syntaxProfiles": {
        "html": {
              "self_closing_tag": "xhtml"
         }
}

@mrmlnc @egamma As of now the "emmet.syntaxProfiles" configuration in VS Code is being used for 2 purposes

"xhtml" is one of the predefined profiles, as in you can use it to say "I want everything just like html, but also want self closing tags".

When "xhtml" is passed as a syntax to emmet, you see the behavior that is described by @Avol-V.
None of the html abbreviations get expanded correctly.

Emmet users know "xhtml" as just a profile that gives everything that html gives + self closing tags.

Therefore, I propose the changes in #18625

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Jan 17, 2017
@ramya-rao-a ramya-rao-a added this to the January 2017 milestone Jan 17, 2017
@ramya-rao-a
Copy link
Contributor

This is now fixed and the fix is in the insiders build

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Jan 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants