Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions API consumption #1881

Closed
3 tasks done
bpasero opened this issue Jan 8, 2016 · 3 comments
Closed
3 tasks done

Extensions API consumption #1881

bpasero opened this issue Jan 8, 2016 · 3 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jan 8, 2016

We changed how extensions consume our vscode.d.ts file. Previously the vscode.d.ts file was always present in the node module and needed to be updated manually. With the new solution, we will download the right version of vscode.d.ts for the extension. See also: #970

PreReq: npm install --g generator-code@next

  • Verify you can generate extensions in TS and JS and you get intellisense for our current stable release properly
  • Verify you can specify a specific VS Code engine in package.json and after npm install you see intellisense for this specific version (e.g. 0.10.3)
  • Verify you can pick the same version as on our master branch and it gets downloaded from master (same works when picking * as version)
  • Verify the version of the vscode.d.ts picked is the semver-minimal-matching versions of our released versions!

You can watch for the output of the npm install command to see what is going on under the hood:

> node ./node_modules/vscode/bin/install

Detected VS Code engine version: ^0.10.6
Found minimal version that qualifies engine range: 0.10.6
Fetching vscode.d.ts from: https://raw.githubusercontent.com/Microsoft/vscode/0.10.6/src/vs/vscode.d.ts
vscode.d.ts successfully installed!
@weinand
Copy link
Contributor

weinand commented Jan 26, 2016

@bpasero node ./node_modules/vscode/bin/install does not work for me since there is no installin the bin directory.

@bpasero
Copy link
Member Author

bpasero commented Jan 26, 2016

@weinand I think something is still weird with your code generator. lets skip that generator and use the following generated sample (right click > save as and then rename from *.gif to *.zip):

sample

@weinand
Copy link
Contributor

weinand commented Jan 26, 2016

@bpasero yes, I had problems with the code generator. After two hours of investigation and removing npm modules from various locations I've learned the following:
On OS X and linux do not install npm modules globally ("-g") by using "sudo". Instead use the shell script available here: https://github.com/glenpike/npm-g_nosudo to configure npm so that it stores global modules in your home directory (without requiring "sudo").

@bpasero bpasero closed this as completed Jan 27, 2016
@egamma egamma mentioned this issue Feb 1, 2016
97 tasks
@alefragnani alefragnani mentioned this issue Feb 4, 2016
5 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants