Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose API/configuration to add supported language IDs for typescript-language-features #200511

Open
johnsoncodehk opened this issue Dec 11, 2023 · 1 comment
Open

Expose API/configuration to add supported language IDs for typescript-language-features #200511

johnsoncodehk opened this issue Dec 11, 2023 · 1 comment
Assignees
@mjbvz
Labels
api feature-request Request for new features or functionality typescript Typescript support issues
Milestone
Backlog

Comments

@johnsoncodehk
Copy link
Contributor

We are migrating the Vue Language Features extension from our own TS LSP server to the TS plugin. I found that some features of typescript-language-features cannot be configured. I can only modify typescript-language-features in a very hacky way. Code to add supported language mode:

https://github.com/vuejs/language-tools/pull/3788/files#diff-3c2b2dc57146f5d52dc996ede798d28b5e6163dcd75762900a25803398a099edR187-R207

I think it is feasible to expose a function like addSupportedLanguageMode() through getAPI(), or configure through contributions.

In addition to Vue, Astro, MDX, and Svelte may also be migrated to TS plugin soon, which will be helpful for related extensions.
@johnsoncodehk johnsoncodehk mentioned this issue Dec 11, 2023
Merged
12 tasks
@RedCMD
Copy link
Contributor

RedCMD commented Dec 11, 2023

related
#198583
#146731

This was referenced Dec 14, 2023
Merged
Closed
@mjbvz mjbvz added this to the Backlog milestone Feb 8, 2024
@mjbvz mjbvz added feature-request Request for new features or functionality api typescript Typescript support issues labels Feb 8, 2024
@yioneko yioneko mentioned this issue Sep 8, 2024
Open
yioneko added a commit to yioneko/vtsls that referenced this issue Sep 21, 2024
@yioneko
fix: disable language mode check in ts extension
0834c3b 
TS plugin may register support for other languages such as vue, augular,
astro, etc. Temporary workaround before
microsoft/vscode#200511 resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
api feature-request Request for new features or functionality typescript Typescript support issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mjbvz @johnsoncodehk @RedCMD