-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add when context: isLastGroup / isFirstGroup / editorGroupIndex #22755
Comments
PR welcome. |
+1 for this. Just switched from vim to vscode recently. Being able to jump back and forth between the sidebar and the first editor group in a similar manner to vim + NERDTree would be great. I'd be happy to take a stab at a PR. @bpasero any advice for implementing this feature? Good places to start, people I should chat with about it, resources on how |
@jaydenwindle maybe look how we update the context for diff editor being active or not: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorPart.ts#L662 |
when
clauses for group metadata
@bpasero is this issue still open for the taking? If yes I would like to be assigned to it. |
@Taguiar looks like it 👍 |
I added |
Just make sure to mention in the release notes that the index starts from 0 which can be confusing since in our UI we name groups GROUP 1, GROUP 2. |
Hm good point, maybe I should change that. |
I pushed a change to start |
Yeah makes sense. Change looks good, so I will not re-verify this. |
I've remapped a shortcut to
View: Focus Next Group
. This command will open an additional group if I'm on the last group and have fewer than 3 groups currently open.It would be great to have a
when
clause to prevent this. A clause likeeditor.isLastGroup
(or perhaps a combination ofeditor.openGroupCount
andeditor.currentGroupIndex
) would allow me to prevent extraneous group opening. A similar check foreditor.isFirstGroup
would let me re-use the same shortcut to jump back and forth between the first group and the sidebar.Thanks for your consideration!
The text was updated successfully, but these errors were encountered: