Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[javascript] TextMate themes don't seem to apply to all keywords #257

Closed
tSte opened this issue Nov 19, 2015 · 4 comments
Closed

[javascript] TextMate themes don't seem to apply to all keywords #257

tSte opened this issue Nov 19, 2015 · 4 comments
Assignees

Comments

@tSte
Copy link

tSte commented Nov 19, 2015

Since last update the default VS Code dark theme has changed (I like the old one because I just don't want bright red colors on the dark background). So I tried (first time I have to admit) create (or modify) a theme via http://tmtheme-editor.herokuapp.com/

Resulting theme is a modification of Visual Studio Dark (uploaded as .txt since .tmTheme is not allowed)
Visual Studio Dark Modified.txt

tmtheme-editor online interprets theme as follows:
image

VS Code however does not interpret theme identically:
image

Please note that this is my first contact with this stuff - I'm not sure if this is an issue related to VS Code of tmtheme-editor

@tSte
Copy link
Author

tSte commented Nov 19, 2015

Okay I found out that class, super and extends are interpreted as 'invalid.illegal' - why are those interpreted that way? My jsconfig.json contains compiler options for ES6...

"compilerOptions": {
"target": "ES6",
}

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

The problem is that our JavaScript tokenizer isn't supporting ES6 yet.

@aeschli aeschli changed the title TextMate themes don't seem to apply to all keywords [javascript] TextMate themes don't seem to apply to all keywords Nov 24, 2015
@tSte
Copy link
Author

tSte commented Nov 24, 2015

I am not sure if ES6 is the problem here... for example the "let" or "const" keywords are classified correctly. But the "new" keyword is not. Object keys are considered (if I am not wrong) to be constants. Document and Array objects poses also different colors.

@aeschli
Copy link
Contributor

aeschli commented Nov 24, 2015

Looking at your code example we need to get ES6 back to work.
duplicate of #133

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants