-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[javascript] TextMate themes don't seem to apply to all keywords #257
Comments
Okay I found out that class, super and extends are interpreted as 'invalid.illegal' - why are those interpreted that way? My jsconfig.json contains compiler options for ES6... "compilerOptions": { |
The problem is that our JavaScript tokenizer isn't supporting ES6 yet. |
I am not sure if ES6 is the problem here... for example the "let" or "const" keywords are classified correctly. But the "new" keyword is not. Object keys are considered (if I am not wrong) to be constants. Document and Array objects poses also different colors. |
Looking at your code example we need to get ES6 back to work. |
Since last update the default VS Code dark theme has changed (I like the old one because I just don't want bright red colors on the dark background). So I tried (first time I have to admit) create (or modify) a theme via http://tmtheme-editor.herokuapp.com/
Resulting theme is a modification of Visual Studio Dark (uploaded as .txt since .tmTheme is not allowed)
Visual Studio Dark Modified.txt
tmtheme-editor online interprets theme as follows:
VS Code however does not interpret theme identically:
Please note that this is my first contact with this stuff - I'm not sure if this is an issue related to VS Code of tmtheme-editor
The text was updated successfully, but these errors were encountered: