Better fonts for CJK users

[iamCristYe]

Hi! Thanks for your efforts in #5260! However, I'm currently experiencing the following issue:

The displayed menu is using a mix of Chinese font and Japanese font(I'm using zh-CN for VS Code in English Windows 10 ). Probably it's because VS Code decides the language from electron API(which uses Windows API to know that English is the system language and Japanese fonts have a priority compared with Chinese in fonts fallback in this case) instead of locale.json. Is it possible to fix that?
And also, for the editor, it would be great to automatically add a line in settings.json like
"editor.fontFamily": "Consolas, Microsoft Yahei UI Light, 'Courier New', monospace"
for zh-CN VS Code users since the default Chinese font for Chinese User is quite ugly. The similar issue may occur for other CJK users.
Thanks! @be5invis

[be5invis]

@iamCristYe
I think it is related to font fallback...
Given that we know the locale you are using we can force the UI typeface...

[iamCristYe]

Yes. zh-CN VS Code under en-US Windows 10. On May 28, 2017, at 11:32, Belleve Invis <[email protected]<mailto:[email protected]>> wrote: @iamCristYe<https://github.com/iamcristye> Are you using zh-CN VSCode under an English OS? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#26175 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMDm4j7hwL7M7B-0tEXRw8uiJDGjoSMRks5r-b3OgaJpZM4NTZCb>.

[be5invis]

@iamCristYe The root case is that Windows does not have an unified typeface family to cover all CCJK languages, so that fallback made inconsistency.
To solve this completely we need time(~2 years), money (~$10M), and technology (perhaps we need to update the format of OpenType if we go beyond 65,535 glyphs).

[iamCristYe]

I totally understand that and we do need a typeface family like Source Han on Windows. But can't we simply assign YaHei to be the font in this case?

…

________________________________ From: Belleve Invis <[email protected]> Sent: Sunday, May 28, 2017 11:54:52 AM To: Microsoft/vscode Cc: Crist Ye; Mention Subject: Re: [Microsoft/vscode] Better fonts for CJK users (#26175) @iamCristYe<https://github.com/iamcristye> The root case is that Windows does not have an unified typeface family to cover all CCJK languages, so that fallback made inconsistency. To solve this completely we need time(2 years), money ($10M), and technology. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#26175 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMDm4lm1UJ2vrigvp_lxAC4QBdmGUPrHks5r-cL8gaJpZM4NTZCb>.

[bpasero]

@iamCristYe can you see how the situation is using our latest insider builds that come with custom menu?
You can give our preview releases a try from: https://code.visualstudio.com/insiders/

[iamCristYe]

@bpasero I'm sorry that currently I'm using Windows with Chinese Interface. I may reinstall the system with English Interface when Windows 10 ver 1809 comes out and hopefully I can give you a comment then.

[bpasero]

OK

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[iamCristYe]

@bpasero The problem has been resolved.