Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add way to open Markdown links in a different editor group #26659

Closed
tedhudek opened this issue May 15, 2017 · 8 comments · Fixed by #80227
Closed

Add way to open Markdown links in a different editor group #26659

tedhudek opened this issue May 15, 2017 · 8 comments · Fixed by #80227
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2019

Comments

@tedhudek
Copy link
Member

Scenario:

Markdown file is open in left editor group. This file has a lot of links to other .md files that I want to preview in the right editor group. But Markdown links can currently only be opened into the same editor.

Please consider. Thanks!
@tedhudek
Copy link
Member Author

Adding @gregvanl per our discussion about this one

@mjbvz mjbvz added feature-request Request for new features or functionality markdown Markdown support issues labels May 15, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 16, 2017

@tedhudek Do you mean that you would like an option to make the open preview to side command to open the preview to the left instead of to the right of the current editor?

@tedhudek
Copy link
Member Author

@mjbvz No, sorry, I should have been more specific. Here's what I mean:

  1. Double-click to open a .md file in a persistent editor in Code, preferably a file with many links to other local .md files.
  2. In the file, Ctrl+click a link to another .md file.
  3. The other file opens in a new editor, in the same editor group.

Desired: open the link as a raw .md file in a new or existing (separate) editor group.
Then, when I go back to the original file and ctrl+click another .md link, open that raw .md into the same editor group the previous one opened into. So I can quickly ctrl+click through a bunch of links and see the raw .md while my original file (the one with all the links) stays in view.

@mjbvz mjbvz added the help wanted Issues identified as good community contribution opportunities label May 17, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented May 17, 2017 •
edited
Loading

Ok, thanks for explaining the expected behavior in more detail. Marking as help wanted if anyone wants to investigate this.

To get started, look at:

@gregvanl gregvanl removed their assignment Jul 18, 2017
@cweekly cweekly mentioned this issue Apr 5, 2018
Closed
txava added a commit to txava/vscode that referenced this issue Sep 2, 2019
@txava
Fix for microsoft#26659.
e133e76 
Clicking on a  local file link will open up the editor on a separate editor group (new or reuse existing one).
@txava txava mentioned this issue Sep 3, 2019
Merged
@mjbvz mjbvz added this to the September 2019 milestone Sep 3, 2019
txava added a commit to txava/vscode that referenced this issue Sep 10, 2019
@txava
Fix for microsoft#26659: Add way to open Markdown links in a differen…
5ff1006 
…t editor group

Adding "markdown.editor.openMarkdownLinks" setting to specify where
links to markdown files should open (current editor group by default).
mjbvz pushed a commit that referenced this issue Sep 10, 2019
@txava @mjbvz
Fix for #26659. (#80227)
c307d73 
* Fix for #26659.

Clicking on a  local file link will open up the editor on a separate editor group (new or reuse existing one).

* Fix for #26659: Add way to open Markdown links in a different editor group

Adding "markdown.editor.openMarkdownLinks" setting to specify where
links to markdown files should open (current editor group by default).
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Sep 10, 2019
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 10, 2019

For verification:

  1. A new setting was added called "markdown.links.openLocation"
  2. There are two options: "currentGroup" (the default) and "beside"
  3. All links in md text files (not the preview) should respect this option
  4. The default behavior should be to open links in the current group

@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@alexr00 alexr00 mentioned this issue Oct 2, 2019
Closed
@alexr00
Copy link
Member

alexr00 commented Oct 2, 2019

Can't verify because of #81849

@sandy081 sandy081 added the verified Verification succeeded label Oct 2, 2019
@sandy081
Copy link
Member

sandy081 commented Oct 2, 2019

I can verify this on Mac.

@tedhudek
Copy link
Member Author

tedhudek commented Oct 2, 2019

Thanks for adding this!

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities markdown Markdown support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2019
Development

Successfully merging a pull request may close this issue.

Fix for #26659. txava/vscode
5 participants
@sandy081 @gregvanl @mjbvz @tedhudek @alexr00