Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] CSS variables should offer same support as SASS/LESS variables #3077

Closed
dstorey opened this issue Feb 17, 2016 · 3 comments
Closed

[css] CSS variables should offer same support as SASS/LESS variables #3077

dstorey opened this issue Feb 17, 2016 · 3 comments
Assignees
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality
Milestone

Comments

@dstorey
Copy link
Member

dstorey commented Feb 17, 2016

With the following code, it should offer to peak/go-to definition when on the var(), the same as for variables in LESS and SASS files:

:root {
    --bg-color: #ccc;
}

body {
  background-color: var(--bg-color);
}

Currently VS Code is not aware of CSS variables.

@dstorey
Copy link
Member Author

dstorey commented Feb 17, 2016

Bonus points if it resolves the variable and shows a colour swatch when used in place of a colour :)

@egamma egamma added css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality labels Feb 18, 2016
@aeschli aeschli added this to the Backlog milestone Feb 22, 2016
@aeschli aeschli changed the title [CSS] CSS variables should offer same support as SASS/LESS variables [css] CSS variables should offer same support as SASS/LESS variables Feb 22, 2016
@gertcuykens
Copy link

sandy081 added a commit that referenced this issue May 18, 2016
sandy081 added a commit that referenced this issue May 18, 2016
@sandy081 sandy081 assigned sandy081 and unassigned aeschli May 19, 2016
@sandy081 sandy081 modified the milestones: May 2016, Backlog May 19, 2016
@egamma egamma mentioned this issue May 19, 2016
87 tasks
sandy081 added a commit that referenced this issue May 19, 2016
sandy081 added a commit that referenced this issue May 20, 2016
sandy081 added a commit that referenced this issue May 20, 2016
Conflicts:
	src/vs/languages/css/common/css.ts
sandy081 added a commit that referenced this issue May 20, 2016
sandy081 added a commit that referenced this issue May 20, 2016
sandy081 added a commit that referenced this issue May 20, 2016
sandy081 added a commit that referenced this issue May 20, 2016
@sandy081
Copy link
Member

Closing this as the changes are merged into the master

@weinand weinand mentioned this issue May 23, 2016
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
css-less-scss Issues and items concerning CSS,Less,SCSS styling feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants