Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet: Implement Reflect CSS Value in emmet extension #31298

Closed
ramya-rao-a opened this issue Jul 24, 2017 · 8 comments
Closed

Emmet: Implement Reflect CSS Value in emmet extension #31298

ramya-rao-a opened this issue Jul 24, 2017 · 8 comments
Assignees
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 24, 2017

Use new emmet modules for implementing "Reflect CSS Value" feature in the emmet extension

The last of the emmet features to be implemented in the emmet extension.
https://docs.emmet.io/actions/reflect-css-value/
Woohoo!

cc @jens1o @vvs @@smlombardi give this one a try in tomorrow's Insiders (July 25)

@vscodebot vscodebot bot added the emmet Emmet related issues label Jul 24, 2017
@ramya-rao-a ramya-rao-a added this to the July 2017 milestone Jul 24, 2017
@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Jul 24, 2017
@vvs
Copy link

vvs commented Jul 25, 2017

Hi @ramya-rao-a , this feature does work with CSS files, but not with SCSS ones. :(

@smlombardi
Copy link

I never use this feature with scss since I always have a process to run Autoprefixer to add all the alternates as needed.

@jens1o
Copy link
Contributor

jens1o commented Jul 25, 2017

Can reproduce what @vvs said.

@ramya-rao-a
Copy link
Contributor Author

@vvs @jens1o Silly me, the command was still using the old implementation (which didn't support scss)

I have made the change to use the right command in the new extension. Should be out in tomorrow's insides.

@jens1o
Copy link
Contributor

jens1o commented Jul 25, 2017

Okay, happy to test that. :)

@vvs
Copy link

vvs commented Jul 26, 2017

The latest insiders build works fine w.r.t. this feature for me, including SCSS. 👍

@jens1o
Copy link
Contributor

jens1o commented Jul 26, 2017

Also working fine for me. :)

@ramya-rao-a
Copy link
Contributor Author

perfect, thanks!

@ramya-rao-a ramya-rao-a added the feature-request Request for new features or functionality label Aug 1, 2017
@roblourens roblourens added the verified Verification succeeded label Aug 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants