Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Realtive file links in terminal are resolved realtive to first folder in workspace, not current working directory #43398

Closed
eloff opened this issue Feb 10, 2018 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues

Comments

@eloff
Copy link

eloff commented Feb 10, 2018

Issue Type

Bug

Description

Create a multi-root workspace. Create files with the same name in both workspace "project" folders. Relative file links should be resolved relative to the current working directory, but you'll see they are resolved relative to the first project in the workspace, even when e.g. running tests in the terminal from the second workspace folder.

VS Code Info

VS Code version: Code 1.20.0 (c63189d, 2018-02-07T17:02:34.244Z)
OS version: Darwin x64 16.7.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz (8 x 2900)
Load (avg) 2, 2, 2
Memory (System) 16.00GB (2.34GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron -psn_0_659617
Screen Reader no
VM 0%
Extensions (4)
Extension Author (truncated) Version
vscode-docker Pet 0.0.24
gitlens eam 8.0.0
Go luk 0.6.74
vscode-proto3 zxh 0.1.2
Reproduces only with extensions
@eloff
Copy link
Author

eloff commented Feb 10, 2018

As an aside, I've been searching all over for a way to set the "primary" or default project in a multi-root workspace. This could allow working around the problem. Is there a way to do that?

@octref
Copy link
Contributor

octref commented Feb 12, 2018

What kind of file are you working on? We fixed that for html, but this is a feature offered by extensions and should be fixed in that specific extension.

@octref octref added info-needed Issue requires more information from poster and removed new release labels Feb 12, 2018
@eloff
Copy link
Author

eloff commented Feb 12, 2018

This is for the integrated terminal, I think it's odd that how relative links are handled in the terminal should depend on the extension used - but you would know better than I would. I'm working with Go files (and the Go extension to vscode.)

@octref octref added the terminal Integrated terminal issues label Feb 12, 2018
@octref
Copy link
Contributor

octref commented Feb 12, 2018

With this API: https://code.visualstudio.com/docs/extensionAPI/vscode-api#_registerDocumentLinkProvider

extensions could register link providers for different files. But for terminal it's a VS Code problem.

@octref octref removed the info-needed Issue requires more information from poster label Feb 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

Duplicate #27107

@Tyriar Tyriar closed this as completed Feb 21, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 21, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

3 participants