Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect font on overall GUI on Japanese environment #4433

Closed
espresso3389 opened this issue Mar 18, 2016 · 6 comments
Closed

Incorrect font on overall GUI on Japanese environment #4433

espresso3389 opened this issue Mar 18, 2016 · 6 comments
Assignees
@dbaeumer
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
April 2016

Comments

@espresso3389
Copy link

  • VSCode Version:
    0.10.12-insider

  • OS Version:
    Windows 10 Build 14291
    Steps to Reproduce:

Basically, VS Code does not use correct Japanese font on VS Code.
It's acceptable on the editor pane if we choose correct font-family.

But recent build introduces Japanese localization on the GUI and
it results in very very ugly look on the status bar and other UI parts.

Some of the glyphs are shown in serif (mincho) font and others are in san-serif (gothic)
and the cause is very apparent; the font is a chinese font, not Japanese one.

image

We need some fix.
Or, there would be some kind of configuration to change the UI font (not editor font).
@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2016

This could potentially be fixed by #4436 - some fonts contain glyphs for multiple locales but the one that is used is based on a few factors.

@bpasero bpasero assigned dbaeumer and unassigned bpasero Mar 21, 2016
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels Mar 21, 2016
@be5invis
Copy link
Contributor

Related #5260
The fallback font shown here is SimSun, which is a serif Simplified Chinese typeface. For Japanese it is completely wrong.
However, AFAIK Electron's font fallback sequence is not good enough either. Perhaps Code needs to write its own style sheet to perform high-quality font fallback sequence for these locales.

@be5invis
Copy link
Contributor


A image of @kenlunde’s LOCL test.
For Source Han Sans, enabling locl feature plus a language tag will perform correct characters for all languages, but since SHS is not installed on most computers, a specific fallback sequence for each language is a better choice.

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2016

@be5invis a good font fallback and setting lang on <html> should hopefully fix both issues. Currently it's set to en-US for all locales which means Chromium doesn't know which glyph to select.

@be5invis
Copy link
Contributor

@Tyriar right.
There are two styles for Chinese is mentioned in #5260. I am not very familiar with Japanese typefaces so I cannot provide a good advice. Maybe you can ask @kenlunde.

@Tyriar Tyriar added the important Issue identified as high-priority label Apr 14, 2016
@Tyriar Tyriar mentioned this issue Apr 14, 2016
Closed
@be5invis be5invis mentioned this issue Apr 15, 2016
Closed
@dbaeumer dbaeumer added this to the April 2016 milestone Apr 18, 2016
@dbaeumer
Copy link
Member

The html lang part is covered by #3841 for which I created a PR
The font part is in length discussed in #5260

I therefore close this one.

@aeschli aeschli added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
6 participants
@be5invis @bpasero @espresso3389 @dbaeumer @Tyriar @aeschli