Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html lang attribute should be set to current locale #4436

Closed
Tyriar opened this issue Mar 18, 2016 · 4 comments
Closed

html lang attribute should be set to current locale #4436

Tyriar opened this issue Mar 18, 2016 · 4 comments
Assignees
@dbaeumer
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
April 2016

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2016

The <html> lang attribute of the editor is set to en regardless of the locale the editor was launched in. This can cause issues, particularly around CJK fonts.
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) labels Mar 18, 2016
@Tyriar Tyriar mentioned this issue Mar 18, 2016
Closed
@egamma egamma added the candidate Issue identified as probable candidate for fixing in the next release label Mar 18, 2016
@dbaeumer
Copy link
Member

@egamma this is a dup of #3841 and no one was brave enough so far to do that change for March. So I proposed to due this for April to get some testing on it. Lets's discuss in standup today.

@egamma egamma removed the candidate Issue identified as probable candidate for fixing in the next release label Mar 21, 2016
@egamma egamma added this to the April 2016 milestone Mar 21, 2016
@egamma
Copy link
Member

egamma commented Mar 21, 2016

Revisit in April

@dbaeumer
Copy link
Member

Dups #3841

@egamma
Copy link
Member

egamma commented Mar 21, 2016

👍

@aeschli aeschli added the verified Verification succeeded label Apr 29, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
April 2016
Development

No branches or pull requests
4 participants
@egamma @dbaeumer @Tyriar @aeschli