-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple fullscreen support #5344
Comments
Did you try |
@egamma yes, this works for full screening VS Code into a new space, but it's not the same a 'simple full screen' where VS Code would full screen without entering a new space on the desktop. |
that is one of the things I really miss compared to Sublime as well. 👍 |
+1 |
2 similar comments
+1 |
+1 |
@subhaze All you have to do is hold down the option key when you click the full screen button and it changes to the old plus button. Is that what you are looking for? |
@richarddavenport nope, that does maximize the editor and is what I currently do. But, it doesn't get rid of the menu/window chrome and actually put the app into "full-screen" mode :( |
+1 |
+1 |
I thought I'd post an update to this thread, since it has had some eyes on it for a while now. Simple (pre-Lion) fullscreen support has just been added in electron/electron#10254 and will (probably) be released in Electron 1.8.x. While I'm sure it will be a little while before vscode fully tests and upgrades to that version of Electron (1.8.0 is still in beta, after all), some of you will be happy to hear that there is at least a light at the end of the tunnel |
+1 |
Any news on this one guys? This feature is the only reason I'm not switching to vscode from sublime. |
Yeah if you have iTerm for example they have the option: Which is really great cause it allows to have a window on top. |
@clankill3r, if you are on a later version of macOS (not sure which one) you can long press the green fullscreen button and it will let you have two windows split in full screen mode. I know that still doesn't solve the overall goal of this issue, but it sounded like you do what I like to do and have my code on one side of the screen and the app running on another. |
On |
This landed on master. To enable, configure |
@bpasero I get "Unknown configuration setting" error when I try to add that to my config file. |
@mesqueeb you will have to wait until tomorrow and then get our insiders build: https://code.visualstudio.com/insiders/ |
@bpasero it doesn't work for the insider build as well, |
We had to stop the insiders build due to a bug, so you will probably only see this next week Monday. |
it's in insiders now! @bpasero there's a 1 or 2 second pause when i switch to simpleFullScreen now that wasn't on my custom build. is that from 9667519#diff-7c4f2973d00eb042eb19c3c3260ae078R523 ? also i don't quite understand what that was fixing. |
@ignu seems quite fast for me, I do not think my change has an impact. That was to fix an issue (that is still there actually) where Electron would return a 0px width for the document while entering or leaving fullscreen. But if you think your delay is caused by it, just comment it out and try it. |
Fyi the setting got renamed from |
I am seeing some weird behavior when using multiple windows and switching between them with cmd+`. Windows no longer rendering but still appearing in the Window menu, or windows completely closing without warning. I'll see if I can get some solid repro steps, but if it's not something with my specific setup then I bet you can repro easily regardless. I had no extensions enabled, and my settings file isn't too crazy. settings.json.txt (Github won't upload JSON files?) |
@kibiz0r if you can distill steps, file a separate issue please. if this feature is too broken in Electron, I will consider to take it out again. I will only tolerate it if it does not cause too many new bugs. |
I'm just on one monitor. I suppose it could potentially be affected by multiple monitors. I'll do a repro today and try it with two monitors as well. |
|
@ignu I (and others: #63291) are seeing a strange behaviour where when entering simple fullscreen, the mouse acts up: it no longer changes its cursor when moving over UI elements, such as the explorer divider to resize it. I also see no hover showing up in the editor when hovering over code. Given these issues (also #5344 (comment)) I think I will have to disable this feature until the underlying issues (possibly in Electron?) are fixed. |
Because it's not enabled by default and at least for me - it works well - can we keep the feature? This has been one of my most anticipated features yet. |
I found a way around it and the feature will remain, however we have to disable the custom titlebar on macOS if this feature is enabled due to issues with the mouse interaction. |
For me it is bugged but I still love it.
|
But you all can just double click on title bar on VSCode and the result is the same. So why even bother to add bugged feature. |
@vivacenontroppo |
It's not the same. I mean, it might seem silly to obsess over the few pixels the menu bar takes up "maximized" in macOS, but I find the aesthetics awful and I'm in my editor too many hours a day. Anyway @clankill3r I'm curious why that happens to you. I fixed that very issue and Simple Fullscreen VS Code should resize itself whenever the resolution changes. (I also seem to have the same flow as you when I take my MacBook home for the night.) |
For me it's not the few pixels the menu bar takes up, for me the important
thing is that when I run my code a new window can come one top off VSCode.
With native fullscreen it goes to another desktop and opens the app there,
and then when I close that app it stays at that desktop. So I have to
switch manually to VSCode, where command + tab often does not work cause
that will go to whatever sceen I don't have in fullscreen. Neither does
command + ~ work cause that never goes to fullscreen applications.
Op wo 28 nov. 2018 om 00:44 schreef Len Smith <[email protected]>:
… It's not the same. I mean, it might seem silly to obsess over the few
pixels the menu bar takes up "maximized" in macOS, but I find the
aesthetics awful and I'm in my editor too many hours a day.
Anyway @clankill3r <https://github.com/clankill3r> I'm curious why that
happens to you. I fixed that very issue and Simple Fullscreen VS Code
should resize itself whenever the resolution changes. (I also seem to have
the same flow as you when I take my MacBook home for the night.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5344 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAtFWlFY0XE7JGpS8HlbQ6ky1nEUW958ks5uzc53gaJpZM4IIV_1>
.
|
I could be missing this in an option somewhere, but if not, it would be awesome if there was an option for "use_simple_full_screen" (like in Sublime Text) which just full screens VS Code in the current window and not create a new space like it does currently.
The text was updated successfully, but these errors were encountered: