-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First hover is no longer syntax-highlighted since 1.25 #53723
Comments
Reproduces and debugged. The markdownRenderer (used by the hover for the code block) accesses the TokenizationRegistry at a time when the grammar is still loaded.
Looks like there has been a timing change due to the change to load the grammar files asynchronously. |
Looks like @aeschli removed support for this and we don't support this any longer. Closing as out-of-scope. |
This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding and happy coding! |
To clarify, what exactly is it that's not supported anymore? Syntax highlighting in hover hints that uses language IDs different from the document language itself? Note that this isn't limited to the Haxe and OCaml extensions, there are even instances of this in (there also appears to be a separate issue with leading |
No, we still support that. The issue is about loading a new language via the hover for the first time. Getting tokenisation for a language used to be coupled with loading it (there is something called |
I see... Is there any workaround, perhaps something that would trigger loading the language grammar in an extension's |
I'll see what I can do to fix this. |
@aeschli thank you |
We noticed a regression in the Haxe extension where the first time a hover hint is shown after VSCode is loaded, it's missing syntax highlighting. For subsequent hovers after that it works fine.
This didn't happen in 1.24:
I think this might be related to using a different grammar / language ID than the text document itself in hover hints (as it seems fine in TS for instance). We have some special language IDs for hover to get it to use a specific scope of the Haxe grammar (
haxe.type
andhaxe.argument
instead ofhaxe
):This issue also affects the vscode-reasonml extension, which does the same thing:
The text was updated successfully, but these errors were encountered: