ITokenizationRegistry to support TokenizationSupport promises #58703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexdima
requested changes
Sep 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #53723
With the latest TextMate changes, grammars are now created asynchronously (due to the async loading of the grammar files and async creation of the textmate engine).
In VSCode, TMSyntax listens on
modeService.onDidCreateMode, then creates the tokenization support and registers it with the TokenizationRegistry.Before that happened in sync. Users (such as the markdownRenderer for the hover) could trigger a mode creation and after that directly access the TokenizationRegistry for the tokenizationSupport.
Now the tokenizationSupport is created asynchronously.
Here's a pragmatic fix where the TokenizationRegistry can return a promise of a tokenizationSupport, and syntax providers can register a tokenizationSupport promise.
The existing sync access (and reacting to change events) is also still supported.
@alexandrudima Let me know if that change is ok for you. I tried to not boil the ocean, but the whole area could need some refactorings, such as decoupling of the initialization of the TokenizationRegistry from the mode service.