Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test decorations in custom views #54939

Closed
2 tasks done
sandy081 opened this issue Jul 24, 2018 · 4 comments
Closed
2 tasks done

Test decorations in custom views #54939

sandy081 opened this issue Jul 24, 2018 · 4 comments
Assignees
Milestone

Comments

@sandy081
Copy link
Member

sandy081 commented Jul 24, 2018

Ref: #47502

Complexity: 2

Set up

Testing

  • Check that you see GIT colors and badges for modified, untracked, and ignored files.
  • Check that you see colors and badges for errors and warnings.
  • Test that you can turn on/off colors and badges via explorer.decorations.colors and explorer.decorations.badges.
  • Check that decorations are in sync with those in file explorer and open editors views.
  • Check that decorations are not shown in other custom views like FTP Explorer.
@sandy081 sandy081 added this to the July 2018 milestone Jul 24, 2018
@weinand
Copy link
Contributor

weinand commented Jul 24, 2018

@sandy081 I hope this item does not involve writing code. If it does, then I don't accept a Complexity below 4!

@sandy081
Copy link
Member Author

@weinand I would provide an example that is already implemented. You can reuse that to test.

@rebornix
Copy link
Member

@sandy081 may I ask that whether this only works for file scheme? I tried this with a custom scheme but file decoration provider is not triggered?

@sandy081
Copy link
Member Author

@rebornix This only works for file scheme as the decorations are supported only for file URIs. There is an issue #54938 to support decorations for all schemes.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants