Add DiagnosticTag.Deprecated

[KamasamaK]

Now that DiagnosticTag has been added to the API, I would like to support the proposal from #51104 to use it for tagging deprecated items.

I figure the associated styling might be a strikethrough as proposed in #50972 but you guys can work that out separately.

[kamranayub]

@jrieken I would be interested in helping out here with this and perhaps even #50972.

Without a lot of context, I assume this issue is specifically to add a new enum member here:

vscode/src/vs/vscode.d.ts

Line 4274 in 03e1318

export enum DiagnosticTag {

I could open a PR that adds a Deprecated member, if that's the case.

edit: Looks like more applicable location would be vscode.proposed.d.ts and then opening a similar PR to #52218

[jrieken]

Yes, vscode.proposed.d.ts is the way to go. Find your way along usages/implementations of Unnecessary

[kamranayub]

Thanks, I'll work on that today.

…

On Mon, Jul 22, 2019, 4:20 AM Johannes Rieken ***@***.***> wrote: Yes, vscode.proposed.d.ts is the way to go. Find your way along usages/implementations of Unnecessary — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#56694?email_source=notifications&email_token=AAEJU24QUT7XLYJZOXNO6HDQAV3W5A5CNFSM4FQG7EU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2PJ5VI#issuecomment-513711829>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEJU22RQDK2SGJJDUVR5GDQAV3W5ANCNFSM4FQG7EUQ> .

[jrieken]

Leaving this open so that we discuss this in the API sync

[jrieken]

API has been finalised.