Linux: dialogs are looking broken in the snap package #57019
Comments
|
@HRK44 in the 1.26 update we moved to Electron 2.0.x and this brings GTK3 dialogs. Are you maybe using a custom theme in Ubuntu that could have an impact? |
|
@bpasero I haven't changed anything in my Ubuntu setup, just upgraded VS code (was working fine with previous version). What kind of information from my settings would be useful for you? |
bpasero
changed the title
bpasero
added
upstream
|
@HRK44 thanks, we should try to reproduce this with a bare Electron to report it to them. Can you:
|
|
Console output:
|
|
@HRK44 looks pretty normal to me. Can you:
|
|
@bpasero I put it inside the callback, it wasn't rendering anything outside (line 25).
|
|
@HRK44 interesting that one looks OK too. Lets try to show the same dialog as the one in code, can you try this dialog instead: |
|
@bpasero I commented the rest of the code (same behavior), the button is not showing for some reason
|
|
@HRK44 try with this: |
|
@bpasero looks fine
|
|
@HRK44 ok here is the exact code to reproduce the same dialog: dialog.showMessageBox(mainWindow, {
buttons: ["Cancel", "_Move"],
cancelId: 0,
checkboxLabel: "Do not ask me again",
defaultId: 1,
message: "Are you sure you want to move 'vsc-extension-quickstart.md'?",
noLink: true,
title: "Code - OSS Dev",
type: "question"
}, function () { }) |
|
@bpasero dialog shows fine
|
|
@HRK44 wow, I am out of ideas on this one. Is there anything logged to VSCode console (run with Does this happen with all dialogs (e.g. try to close a dirty file)? |
|
Here is the console when I start [16397:0823/132212.476507:WARNING:browser_main_loop.cc(275)] Gtk: Locale not supported by C library.
It happens with all dialogs. |
|
More logs : ESC[90m[main 1:50:46 PM]ESC[0m windowsService#showMessageBox 1
[19768:0823/135133.139056:WARNING:browser_main_loop.cc(275)] Gtk: Error loading image 'file:///usr/share/themes/Ambiance/gtk-3.0/assets/button-default-focused-hover.png': Unable to load image-loading module: /usr/lib/x86_64-linux-gnu/gdk-pixbuf-2.0/2.10.0/loaders/libpixbufloader-png.so: /snap/core/current/lib/x86_64-linux-gnu/libz.so.1: version |
|
@HRK44 good one, I think this is because we are using a PNG icon for the dialog and that seems to break the dialog. Can we try that with the
and the icon being:
|
|
@bpasero it works fine with the png icon. It might have something to do with this issue : https://forum.snapcraft.io/t/skype-exits-when-trying-to-add-a-file-to-a-chat/6138/8
After further searching, there is this issue, that might be on the same problem. |
|
@bpasero I tried some stuff but couldn't manage to successfully update this ZLIB without creating a bunch of system issues, if someone with more advanced skills in Linux would try that'd be great. |
Tyriar
added
bug
|
@HRK44 thanks! FYI @flexiondotorg |
Tyriar
added
install-update
|
For reference, the issue is not due to an incorrect zlib version suggested above. The problem is due to the snap accidentally referencing system libraries instead of it's own. This manifests with vscode loading the libgdk-pixbuf-loader library from the system, which is compiled against a different zlib than the one within the snap's files. The solution, therefore, is not to mess about trying to change the zlib version but to determine why it is using the system libraries in the first place. I'll try to look at it tomorrow, or @popey or @flexiondotorg might beat me to it. |
|
Any chance on getting a status update on this issue? I am facing the same thing. It would be no great hardship to try HRK44's solution but if there's any hope of seeing this resolved in the near-term I'd just as soon stick with the snap. |
|
Today, I got VSCode version 1.32.3 (via Snap!) and the bug seems to be fixed! |
|
Whereas 1.32.3 is the first version I've noticed has this problem. I reverted to 1.31.1 (I'm using Snap, by the way) and the problem went away. I then refreshed back to 1.32.3 and the problem returned. |
|
Thanks to @flexiondotorg, this is now fixed in |
|
Still broken having removed Snapcrafter's vscode snap and installed code 1.33. :-( |
Adds the PPA for the GNOME 3.26 framework which is maintained by the Ubuntu Desktop team. This PPA includes GTK3 and GNOME3 components used to create the GNOME 3.26 Framework snap for Ubuntu 16.04. * Fixes: microsoft#63194 * Fixes: microsoft#57019
vscode version :
Version: 1.26.1
Commit: 493869e
Date: 2018-08-16T18:34:20.517Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64
OS Version:
Distributor ID: Ubuntu
Description: Ubuntu 18.04.1 LTS
Release: 18.04
Codename: bionic
Steps to Reproduce:
When I hover the buttons, they appear. But as you can see, the modal header has some dark black color.
Does this issue occur when all extensions are disabled?: Yes
The text was updated successfully, but these errors were encountered: