Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Links are broken #57891

Closed
octref opened this issue Sep 4, 2018 · 6 comments
Closed

Terminal Links are broken #57891

octref opened this issue Sep 4, 2018 · 6 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@octref
Copy link
Contributor

octref commented Sep 4, 2018

It's working in 1.26.1 but not in Insiders.

Repro:

  • npm i -g serve
  • Run it in terminal

1.26.1 (left) vs Insider (right):

terminal-bug

Marking as important since this impact:

  • People running cli tools that output file paths for errors, such as webpack
  • People running local versions of website
@octref octref added important Issue identified as high-priority candidate Issue identified as probable candidate for fixing in the next release terminal Integrated terminal issues labels Sep 4, 2018
@octref octref added this to the August 2018 milestone Sep 4, 2018
@octref octref added the info-needed Issue requires more information from poster label Sep 4, 2018
@octref
Copy link
Contributor Author

octref commented Sep 4, 2018

This somehow does not repro now, although it repros a minute ago...
I'll find out the exact repro steps and update the issue.

@octref octref removed the important Issue identified as high-priority label Sep 4, 2018
@octref octref removed this from the August 2018 milestone Sep 4, 2018
@Tyriar Tyriar removed the candidate Issue identified as probable candidate for fixing in the next release label Sep 4, 2018
@Tyriar
Copy link
Member

Tyriar commented Sep 4, 2018

I can't repro either and I looked at the code and nothing i sticking out as obviously wrong. Let me know if you see against and get a reliable repro.

@Tyriar Tyriar closed this as completed Sep 4, 2018
@schmamps
Copy link

schmamps commented Sep 5, 2018

Updated from 1.26 to 1.27.0 (mainstream, High Sierra) today and having this issue with file paths, but not URLs.

# link works
echo "http://localhost:8000/"
http://localhost:8000/
# link does not work
$ mypy package
package/module.py:8: error: Name 'string' is not defined

@schmamps
Copy link

schmamps commented Sep 5, 2018

…and it's still broken after I downgraded to 1.26. Is this xterm?

@maxshelley
Copy link

Updated from 1.26 to 1.27.0 (mainstream, High Sierra) today and having this issue with file paths, but not URLs.

I also have the same issue and can confirm it only seems to be affecting file paths but not URLs.

Possible duplicate of #57987?

Let me know if there's any debugging info I can provide.

@Tyriar
Copy link
Member

Tyriar commented Sep 10, 2018

Tracking this in #58256 now

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

4 participants