-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot click relative paths in terminal #58256
Comments
Related:
I bet @Tyriar can fix it ;F What is worng?It looks like there is problem with current working directory: It really looks like
|
I am working on it! Edit: I am stuck :| There is confirmation that newest version from GitHub repository is also not going very well Edit: |
@PsychoXIVI wow, nice investigation! @octref noticed links not working but we couldn't repro after that, this being a race condition makes sense as to why we couldn't repro so easily. I've definitely seen it before as well. A PR would be awesome if you can put it together quick, this might go in the recovery build that we will probably release next week so if you can put a fix together in the next couple of days that would be best. I think the best and easiest fix here is use |
After working with it for some time, I can say only that is appears to be randomly (?) bugged. I will try to use another approach: detecting current working directory of the process form terminal. Edit: It can't be easily done because of Windows is stupid as fuck and cannot provide simplest API function to read CWD of the process (only availble via raw, cross-process memory access (here AHK code?) :| ). It can be possible for lovely Linux, as always as simple as single shell command: |
@PsychoXIVI we only need the initial cwd to be set to fix this regression. Getting the actual cwd in realtime is another feature which is a bunch of work (mainly because it's tough on Windows currently). |
I had the similar issue on Mac OSX, I can not hold the Command and click the relative path. |
@PsychoXIVI I think I'll put the fix together for this today as it will likely be included in 1.27.2, thanks again for the investigation! |
Fixed in |
|
Just tried out 1.27.2, the issue still exists. 1.26.x is also broken but 1.25.x works fine. (macOS 10.13.6) |
@szhu can you share a screenshot and text of the failing line? |
|
I noticed that links that wrap are no longer working. :( |
@szhu folders never worked. #29499 @somewhatabstract works for me: |
@somewhatabstract that's an unrelated bug that should get fixed with #23688 |
It worked for me before, Now it is disabled. |
@b00f did you update to 1.27.2? Please report a new issue if so. |
@Tyriar Thanks. It is fixed in this version. Hopefully you have integration test for this feature then it won't be an issue in later versions. |
Issue Type: Bug
Run a compiler on a file with an error, and hold down the Alt button and click on the pathname. Nothing happens.
VS Code version: Code 1.27.1 (5944e81, 2018-09-06T09:21:18.328Z)
OS version: Windows_NT x64 6.1.7601
System Info
checker_imaging: disabled_off
flash_3d: unavailable_software
flash_stage3d: unavailable_software
flash_stage3d_baseline: unavailable_software
gpu_compositing: unavailable_software
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_software
video_decode: unavailable_software
video_encode: unavailable_software
webgl: enabled_readback
webgl2: unavailable_off
Extensions (15)
The text was updated successfully, but these errors were encountered: