Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the typescript plugins extension point dynamic #67575

Closed
mjbvz opened this issue Jan 30, 2019 · 4 comments
Closed

Make the typescript plugins extension point dynamic #67575

mjbvz opened this issue Jan 30, 2019 · 4 comments
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2019

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 30, 2019

Part of #66574

Tracks making the typescript plugins extension point dynamic

We should restart the TS server if contributed plugins change.
@mjbvz mjbvz added the feature-request Request for new features or functionality label Jan 30, 2019
@mjbvz mjbvz added this to the February 2019 milestone Jan 30, 2019
@mjbvz mjbvz self-assigned this Jan 30, 2019
This was referenced Jan 30, 2019
Closed
Closed
mjbvz added a commit that referenced this issue Feb 12, 2019
@mjbvz
Make the typescript plugins contribution point dynamic
a8216d4 
Part of #67575
@kieferrm kieferrm mentioned this issue Feb 19, 2019
Closed
35 tasks
@mjbvz
Copy link
Collaborator Author

mjbvz commented Feb 21, 2019

Final part of fix in d73fdb0

@mjbvz mjbvz closed this as completed Feb 21, 2019
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Feb 24, 2019
@alexr00 alexr00 added the verification-steps-needed Steps to verify are needed for verification label Feb 26, 2019
@octref
Copy link
Contributor

octref commented Feb 26, 2019

@mjbvz Ping for verification steps

@mjbvz
Copy link
Collaborator Author

mjbvz commented Feb 26, 2019

  1. In a workspace with tslint setup, such as the vscode source (but without any tslint extension installed)
  2. Open file and delete a semicolon. Confirm no tslint alerts
  3. Install the tslint extension: https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin
  4. Now the tsserver should restart and tslint should be enabled and alert about the missing semicolons

@octref
Copy link
Contributor

octref commented Feb 26, 2019

Verified.

@octref octref added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Feb 26, 2019
@mjbvz mjbvz added verified Verification succeeded and removed verified Verification succeeded labels Feb 26, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2019
Development

No branches or pull requests
3 participants
@octref @mjbvz @alexr00