Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit need for node/electron-browser in workbench/contrib/tasks #69113

Closed
bpasero opened this issue Feb 21, 2019 · 2 comments
Closed

Revisit need for node/electron-browser in workbench/contrib/tasks #69113

bpasero opened this issue Feb 21, 2019 · 2 comments
Assignees
@alexr00
Labels
debt Code quality issues web Issues related to running VSCode in the web
Milestone
June 2019

Comments

@bpasero
Copy link
Member

bpasero commented Feb 21, 2019

Refs #68302

I am not sure why src/vs/workbench/contrib/tasks has to have most of its files in electron-browser land. Please consider lifting this to browser if possible.

If there is something blocking this task, speak up and we need to think about introducing new services as needed.

//cc @dbaeumer
@bpasero bpasero added the debt Code quality issues label Feb 21, 2019
@dbaeumer
Copy link
Member

Major reason is that the ProcessTaskSystem depends on node API to spwan processes. Even the TerminalTaskSystem as some dependencies for FS API to find executables in win32 land.

Since the task service depends on them (no registry right now) it pulls everything else into electron browser.

IMO the right solution to fix this is to move task execution completely to the extension host where we have node APIs by definition.

@bpasero
Copy link
Member Author

bpasero commented Feb 21, 2019

IMO the right solution to fix this is to move task execution completely to the extension host where we have node APIs by definition.

Yes 👍

@bpasero bpasero mentioned this issue Feb 21, 2019
Closed
17 tasks
@alexr00 alexr00 added this to the March 2019 milestone Feb 22, 2019
@alexr00 alexr00 modified the milestones: March 2019, May 2019 Mar 4, 2019
@bpasero bpasero added the web Issues related to running VSCode in the web label May 9, 2019
@alexr00 alexr00 modified the milestones: May 2019, June 2019 May 27, 2019
alexr00 added a commit that referenced this issue Jun 14, 2019
@alexr00
Remove use of win32 from terminal task system
c791578 
Part of #69113
alexr00 added a commit that referenced this issue Jun 14, 2019
@alexr00
Remove getWindowsBuildNumber from terminal task system
03394ab 
Per discussion in #67855, using the build number didn't solve the issue. For web we need to remove this dependency anyway. Part of #69113
alexr00 added a commit that referenced this issue Jun 14, 2019
@alexr00
Remove terminal task dependency on getDefaultShell
c43b97e 
Part of #69113
@alexr00 alexr00 mentioned this issue Jun 17, 2019
Merged
alexr00 added a commit that referenced this issue Jun 18, 2019
@alexr00
Remove some uses of process in tasks
416f8ac 
The terminal task system still has references to process that affect only Windows. This change removes some of those references

Part of #69113
@alexr00 alexr00 closed this as completed Jun 20, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
debt Code quality issues web Issues related to running VSCode in the web
Projects
None yet
Milestone
June 2019
Development

No branches or pull requests
3 participants
@bpasero @dbaeumer @alexr00