-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to save file after renaming occurred #72343
Comments
@bpasero for changes in the file service |
I think I am seeing this with typescript too. |
@fbricon can I ask you to please try to reproduce this from our latest insider version: You can give our preview releases a try from: https://code.visualstudio.com/insiders/ If it reproduces: is that class you are renaming used anywhere outside? Could you give me a minimal repository to reproduce that I can clone? |
I can reproduce with Insiders 1.34 (6d5feae 2019-04-17T09:11:24.577Z).
|
@fbricon thanks, I see it. |
@fbricon pushed a fix, it would be great if you could verify it from an insiders build starting today or later. |
I confirm the problem is fixed in the Insiders build |
@fbricon thank you |
This issue was initially reported as redhat-developer/vscode-java#871
Does this issue occur when all extensions are disabled?: Maybe
I checked the problem doesn't occur with VS Code 1.32.3, so the regression was introduced in 1.33
The text was updated successfully, but these errors were encountered: