Rename class won't save the file

[samba2]

When renaming a class (F2) the class symbol and the file itself are renamed properly. However, when I try to save the file the following error is displayed:

Failed to save 'NewName.java': The content on disk is newer. Please compare your version with the one on disk.

When I now click on the compare button (part of the error popup) and accept the change then the renamed class is eventually saved.

Environment

• Operating System: Windows 10
• JDK version: jdk1.8.0_181
• Visual Studio Code version: 1.33
• Java extension version: 0.42.1

Steps To Reproduce

1. create new file MyClass.java
2. inside MyClass.java expand the template"class" which gives you a skeleton for MyClass
3. position the cursor inside the symbol MyClass
4. press F2 (rename)
5. enter NewName
6. the mentioned error popup is displayed
7. press Compare
8. accept new version
9. NewName.java is saved

Current Result

Extra step to save/ accept the renamed class.

Expected Result

After changing the name of the class via F2, the class symbol as well as the file name are changed and saved.

Additional Informations

When autosave is turned on the error occurs instantly, with autosave turned off the error popup is displayed when saving manually.

[yaohaizh]

Reproed this issue on the latest version.

[V-Klein]

I can reproduce this issue.
Operating System: Windows_NT x64 10.0.17134
JDK version: openjdk version "11.0.2" 2019-01-15
Visual Studio Code version: 1.33.1
Java extension version: 0.42.1

[fbricon]

Indeed, this is new. Looks like a bug in vscode, since jdt.ls hasn't changed anything in that area in a long time.

[fbricon]

I've opened microsoft/vscode#72343 upstream

[fbricon]

The problem is fixed in VSCode. You can use the Insiders build until the next official release (1st week of May, probably)

[GabrielBB]

Great. I'll wait for the next official release then