Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode cannot read property 'trim' of null error with vscode insider 1.35 #73867

Closed
ttbug opened this issue May 17, 2019 · 28 comments
Closed

vscode cannot read property 'trim' of null error with vscode insider 1.35 #73867

ttbug opened this issue May 17, 2019 · 28 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@ttbug
Copy link

ttbug commented May 17, 2019

Issue Type: Bug

when i debug python file, set breakpoint and F5 ,vscode cannot read property 'trim' of null error occured in vscode insider 1.35, while 1.34.20 works well,so i install 1.34.20 again.

VS Code version: Code - Insiders 1.34.20-insider (e83e24a, 2019-05-15T18:06:45.467Z)
OS version: Windows_NT x64 10.0.17763
Remote OS version: Linux x64 4.9.0-9-amd64

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.87GB (5.42GB free)
Process Argv
Screen Reader no
VM 50%
Item Value
Remote SSH: alias
OS Linux x64 4.9.0-9-amd64
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (2 x 2807)
Memory (System) 3.85GB (0.55GB free)
VM 100%
Extensions (14)
Extension Author (truncated) Version
code-runner for 0.9.9
pyright ms- 1.0.28
python ms- 2019.4.12954
Go ms- 0.10.2
autoimport ste 1.5.3
vscodeintellicode Vis 1.1.6
vscode-language-pack-zh-hans MS- 1.34.2
remote-containers ms- 0.53.0
remote-ssh ms- 0.37.0
remote-ssh-edit ms- 0.37.0
remote-ssh-explorer ms- 0.37.0
remote-wsl ms- 0.35.0
vscode-remote-extensionpack ms- 0.14.0
material-icon-theme PKi 3.7.0

(1 theme extensions excluded)

@zzzJH
Copy link

zzzJH commented May 17, 2019

the same problem after update 1.35.0-insider

@jerrylususu
Copy link

jerrylususu commented May 17, 2019

same bug too, on 1.35.0-insider, appears whenever I start debugging on Java.
Local OS: Windows 10 1903, x64
Remote OS: WSL - Ubuntu 18.04

@ypapouin
Copy link

Link to previous version:
https://update.code.visualstudio.com/1.34.20-insider/win32-x64-user/insider

@magic-k
Copy link

magic-k commented May 17, 2019

It worked yesterday with 1.35 so this problem came with todays update

@AeneasZhu
Copy link

I also have this problem too on the 'Exploration' Version. So I switch to Insider Version of 1.34, but when it update today, the same bug happened again.

@allenwu5
Copy link

@beachbc
Copy link

beachbc commented May 17, 2019

You can work around this issue by updating your launch.json with "console": "internalConsole"

Python: Current File example:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "internalConsole"
        }
    ]
}

@katsos
Copy link

katsos commented May 18, 2019

Is anyone working on this one? I can give it a try

@bevo009
Copy link

bevo009 commented May 18, 2019

FYI the console workaround "console": "internalConsole" doesn't work with any input(), otherwise I would just use code runner until this was fixed.
A bit maddening that any restart reinstalls the borked 1.35.0, now I have to reinstall 3.4 AGAIN to get around this bug? Why don't you flag borked upgrades as incompatible so vscode-insiders ignores them? Forcing buggy installs doesn't seem a positive path to take...

@rchinna
Copy link

rchinna commented May 18, 2019

Hit the same issue, thanks to @beachbc for the workaround.

@Sherlock92
Copy link

same issue here, dg to 1.35 for now. I'm not so familiar with vscode otherwise i would like to contribute

@roblourens
Copy link
Member

Another possible workaround: set the terminal to bash: microsoft/vscode-remote-release#350 (comment)

@Cow258
Copy link

Cow258 commented May 20, 2019

Same issue here...
Unable to debug any Node.js project for now.
And some log can't display on "internalConsole".
So I switch back to VSCode for this moment.

{
    "version": "0.2.0",
    "configurations": [
     {
            "name": "New Debug",
            "type": "node",
            "request": "launch",
            "runtimeExecutable": "nodemon",
            "runtimeArgs": ["--inspect=9229", "--expose-gc", "--gc_global", "--nouse-idle-notification", "--max-old-space-size=250", "app.js"],
            "restart": true,
            "console": "integratedTerminal",
            "protocol": "inspector",
            "port": 9229
        }
    ]
}

image

@guyhuang
Copy link

You can work around this issue by updating your launch.json with "console": "internalConsole"

Python: Current File example:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "internalConsole"
        }
    ]
}

That's the answer. But I donnot know why. Maybe corrected in release version.

@egamma egamma added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels May 20, 2019
@egamma
Copy link
Member

egamma commented May 20, 2019

Adding the important label since the breaks the 'vscode-remote-try-python' sample.

@Tyriar Tyriar added this to the May 2019 milestone May 20, 2019
@Tyriar
Copy link
Member

Tyriar commented May 20, 2019

@isidorn please review 15a0e88

@Tyriar Tyriar closed this as completed in 15a0e88 May 20, 2019
@norbinsh
Copy link

You can work around this issue by updating your launch.json with "console": "internalConsole"

Python: Current File example:

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "internalConsole"
        }
    ]
}

This works - changing to internal console.

Thanks.

@liedav
Copy link

liedav commented May 20, 2019

I have the same issue: vscode cannot read property 'trim' of null when running python code with/without debug in version 1.35, whereas 1.34.20 works. I have tried the workaround of replacing "console": "integratedTerminal" with "console": "internalConsole" in the launch.json file and it did NOT work for me. I have reverted back to 1.34.20.

@PeterJPRoche
Copy link

Having the same issue debugging Python code. VS Code - Insiders 1.35.0. The workaround of replacing "console": "integratedTerminal" with "console": "internalConsole" worked for me (thankfully!)

@weinand weinand self-assigned this May 21, 2019
@yamcenutzer
Copy link

which commit fixes this? I don't see any change.

@weinand
Copy link
Contributor

weinand commented May 22, 2019

@yamcenutzer Commit 15a0e88. See 4 comments above:

2019-05-22_16-38-51

I've verified that all issues resolved as duplicates now work with the fix.

@yamcenutzer
Copy link

either that commit isn't in 1.35.0

  • or it doesn't help with remote cpp debug with gdb.
  • or the cpp exension needs to know about "console" (which it doesn't)
  • or the remote extension doesn't know about it

Like I said, I have no idea whether my original issue, which was about remote cpp debugging on real linux (not WSL, ever), is the same as this one. There are 3 teams involved, which in the, past, seem to not know of each other: vscode, cpp, and as of recently: remote-ssh.

So I ask again, do I need to ask someone else, or simply wait until my insiders build offers me an update beyond 1.35.0?

@weinand
Copy link
Contributor

weinand commented May 22, 2019

@yamcenutzer but you are setting the externalConsole in your launch config to false, correct?

BTW, vscode and remote-ssh are the same team.

@yamcenutzer
Copy link

yes,
and that's nice...

If you say it should be in 1.35.0, then I'll reinstall from scratch..

@weinand
Copy link
Contributor

weinand commented May 22, 2019

@yamcenutzer and you are seeing the "cannot read property 'trim' of null error" or the never ending progress indicator?

@yamcenutzer
Copy link

yamcenutzer commented May 22, 2019

never ending progress...

hangon...
I'm installing again, I believe I'm getting updates now...

got updates to a new commit dated yesterday , this could work:
Version: 1.35.0-insider (user setup)
Commit: 4ca38ce
Date: 2019-05-21T05:18:31.618Z
Electron: 3.1.8
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 6.1.7601
....

and it does...
seems a bit flaky, as it sometimes gets funny characters ~~~ and then complains about them.
but if it gets past that stage, it works at least on the simple 'hello' example I have right here

OK Thx

@bevo009
Copy link

bevo009 commented May 23, 2019 via email

@isidorn
Copy link
Contributor

isidorn commented May 23, 2019

@Tyriar thanks for fixing. The fix looks good.

@Tyriar Tyriar added the verified Verification succeeded label May 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests