Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First hover is no longer syntax-highlighted again #78946

Closed
Gama11 opened this issue Aug 12, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Closed

First hover is no longer syntax-highlighted again #78946

Gama11 opened this issue Aug 12, 2019 · 4 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded
Milestone
August 2019

Comments

@Gama11
Copy link
Contributor

Gama11 commented Aug 12, 2019

Recently, I've been noticing the exact same issue as described in #53723 again. Possibly this has regressed in the 1.37 release.
@alexr00
Copy link
Member

alexr00 commented Aug 13, 2019

Leaving for @aeschli.

@alexr00 alexr00 removed their assignment Aug 13, 2019
@aeschli
Copy link
Contributor

aeschli commented Aug 20, 2019

I'm able to reproduce with the haxe sample.

@alexandrudima I believe the problem is here:

vscode/src/vs/workbench/services/textMate/browser/abstractTextMateService.ts

Line 231 in b0d58e4

this._tokenizersRegistrations.push(TokenizationRegistry.registerPromise(modeId, promise));

The _tokenizersRegistrations promise is only registered once the _getOrCreateGrammarFactory is completed. It also needs to go in the promise.

I can do the fix, if thats ok for you.

@alexdima
Copy link
Member

@aeschli I think this was a regressions from my recent refactorings. I'd like to understand it...

@alexdima alexdima assigned alexdima and unassigned aeschli Aug 20, 2019
@alexdima alexdima added this to the August 2019 milestone Aug 20, 2019
@gjsjohnmurray gjsjohnmurray mentioned this issue Aug 22, 2019
Closed
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover labels Aug 28, 2019
@alexdima
Copy link
Member

Repro steps:

  1. Open a fresh VS Code with a .js file.
  2. Be sure to not open by accident a TS file before or in parallel
  3. Hover over something in the .js file
  4. The first hover is not colored:
    image

@octref octref added the verified Verification succeeded label Aug 29, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
5 participants
@Gama11 @octref @alexdima @aeschli @alexr00