Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visible output channel output is delayed #79431

Closed
NikGovorov opened this issue Aug 19, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Closed

Visible output channel output is delayed #79431

NikGovorov opened this issue Aug 19, 2019 · 6 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues verified Verification succeeded
Milestone

Comments

@NikGovorov
Copy link

NikGovorov commented Aug 19, 2019

Version: 1.38.0-insider (user setup)
Commit: 4fa0890
Date: 2019-08-19T05:39:53.031Z
Electron: 4.2.9
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17763

Please see #59209 (comment) for the steps to reproduce and more details.

CC: @sandy081

@vscodebot
Copy link

vscodebot bot commented Aug 19, 2019

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@NikGovorov
Copy link
Author

Stable:
vscode-failing-tests-pane-stable
Insiders:
vscode-failing-tests-pane

@NikGovorov NikGovorov changed the title Output channel output is delayed Visible output channel output is delayed Aug 19, 2019
@sandy081
Copy link
Member

@NikGovorov Is that the latest stable? If so there are no changes done in output channel. Please file an issue against the extension to check if it is caused by the extension.

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Aug 26, 2019
@ArtemGovorov
Copy link
Contributor

@sandy081 It is reproducible in the latest insiders and is not caused by the extension.

Here is the easiest way to reproduce it:

  • install Quokka extension,
  • in latest stable here is how it responds to changes:

q1

  • in the latest insiders:

q

Looks like this change of yours #59209 (comment) is not applied anymore in insiders. Maybe it is the result of these changes

export class ExtHostOutputService2 extends ExtHostOutputService {
(cc @jrieken ) ?

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug output Output channel system issues and removed info-needed Issue requires more information from poster labels Aug 28, 2019
@sandy081 sandy081 added this to the August 2019 milestone Aug 28, 2019
@sandy081
Copy link
Member

@ArtemGovorov Thanks for info.

Yes, it is broken by our recent changes. @jrieken FYI

Fixed.

@jrieken
Copy link
Member

jrieken commented Aug 28, 2019

Thanks @sandy081

hunghw pushed a commit to hunghw/vscode that referenced this issue Aug 28, 2019
@alexr00 alexr00 added the verified Verification succeeded label Aug 29, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug output Output channel system issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants