Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patternPos isn't working correctly #79815

Closed
jrieken opened this issue Aug 26, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Closed

patternPos isn't working correctly #79815

jrieken opened this issue Aug 26, 2019 · 2 comments · Fixed by microsoft/azuredatastudio#7206
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
August 2019

Comments

@jrieken
Copy link
Member

jrieken commented Aug 26, 2019

Run fuzzyScore with :p against prop, using pattern pos 1. the result is pro^p, not ^prop
@jrieken jrieken self-assigned this Aug 26, 2019
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete labels Aug 26, 2019
@jrieken jrieken added this to the August 2019 milestone Aug 26, 2019
jrieken added a commit that referenced this issue Aug 26, 2019
@jrieken
simple change for #79815
1126817
@octref octref added the verification-steps-needed Steps to verify are needed for verification label Aug 29, 2019
@octref
Copy link
Contributor

octref commented Aug 29, 2019

@jrieken Any verification steps, or just through code review?

@jrieken
Copy link
Member Author

jrieken commented Aug 30, 2019

There is a unit test, so some confidence, but you can verify using quick outline, with the @: prefix, e.g have a class with method prop and search for @:p

@jrieken jrieken removed the verification-steps-needed Steps to verify are needed for verification label Aug 30, 2019
@alexr00 alexr00 added the verified Verification succeeded label Aug 30, 2019
@anthonydresser anthonydresser mentioned this issue Sep 13, 2019
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
August 2019
Development

Successfully merging a pull request may close this issue.

Merge from vscode 64980ea1f3f532c82bb6c28d27bba9ef2c5b4463 microsoft/azuredatastudio
3 participants
@jrieken @octref @alexr00