-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Grid Layout #79845
Comments
@isidorn Not sure what those numbers are? The perf bot still didn't show a real difference between today and yesterday: https://vscodeteam.slack.com/archives/C3NBSM7K3/p1566914782011400 |
@jrieken Those number are |
So, you measuremented was enable/disable grid layout, right? Since the perf bot measures everything there might be something else that's now slower... |
@jrieken yes. Since I can enable/disable it via the setting The bot is comparing Grid from today from grid from tomorrow. |
@jrieken the perf from today definitely seems better. When you originally called out the perf degradation, we were at ~1800ms and 50ms slower you said. With that, my target would have been ~1750ms which this did not hit but 1769ms is closer. But I also notice that from day to day this number has lots of variance. Looking at the last few days the spread of the 10 runs shows many slow runs whereas with today's runs the majority are at or below ~1780ms |
Yeah, we had lost 50ms when enabling the grid but during the last days the perf bot had some fast runs (that's why I wondered when the changes have been merged). I believe @isidorn when he measured locally using the toggle-setting approach. It just seems that the perf bot lost time somewhere else... There was a pending update (which usually makes everything run slower) which is now installed |
Testing: #50853 #79614
Complexity: 5
I've marked this issue as high complexity as I believe it should have strenuous testing to uncover any potential regressions between the new and old layout.
The grid layout is enabled by default and has been for the entire iteration. However, a perf improvement PR was merged just before endgame regarding the initial (re)construction of the workbench.
How to verify
Ensure that you haven't disabled the grid layout setting.
What is cached with the layout on a workspace level and application level can be confusing when testing. Please always verify that the behavior has changed from stable when reporting a new issue. It's a good idea to use the same settings and document your steps along the way for longer repros.
The text was updated successfully, but these errors were encountered: