Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid layout: hidding editor area should be done group by group #79899

Closed
isidorn opened this issue Aug 27, 2019 · 9 comments
Closed

Grid layout: hidding editor area should be done group by group #79899

isidorn opened this issue Aug 27, 2019 · 9 comments
Assignees
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues *out-of-scope Posted issue is not in scope of VS Code

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 27, 2019

Refs: #79845

When we resize the sidebar or the panel on the side, and there is not enough space we decide to hide the editor area. This is a great feature and I like it.

However if in the editor area there are two groups side by side, it would be very nice that we firs thide one group, and only later the other.
Since currently we just hide the complete editor area. Which is not nice, since sometimes there is more than enough space for one group to still be shown.
Due to the current approach the whole thing feels a bit jarring and not smooth.

snap

@isidorn isidorn added feature-request Request for new features or functionality layout General VS Code workbench layout issues labels Aug 27, 2019
@sbatten
Copy link
Member

sbatten commented Aug 27, 2019

whoa, that's some advanced tech :P

@joaomoreno
Copy link
Member

joaomoreno commented Aug 30, 2019

Yeah nice to have, yet unlikely unless we place editors the same grid as the workbench. I would simply close this.

I'm also not a big fan of having the editor view snappable btw, @sbatten, which causes situations like this. IMO the terminal should have been snapped out, in @isidorn's GIF.

@joaomoreno joaomoreno removed their assignment Aug 30, 2019
@isidorn
Copy link
Contributor Author

isidorn commented Aug 30, 2019

Agree that the editors should be the last to snap. We are a code editor after all and the editor part should have priority

@sbatten
Copy link
Member

sbatten commented Aug 30, 2019

with toggle panel maximized being effectively the same as hiding the editor, I could be convinced that snapping is not necessary on the editor since you have a mouse action in the panel available to do this.

@joaomoreno
Copy link
Member

I could be convinced

Then, I cast my spell: João attempts to convince SteVen.

@sbatten
Copy link
Member

sbatten commented Sep 2, 2019

Hmmm what's your charisma stat? rolled a d20 and got a 4 :p

@isidorn
Copy link
Contributor Author

isidorn commented Sep 2, 2019

18, that makes it 8 in total. He has some diplomacy skill points to add on top of that.

@joaomoreno
Copy link
Member

Listen to @isidorn, he last held my character sheet.

@sbatten sbatten added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality layout General VS Code workbench layout issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants