Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test selection decorations in the minimap #81689

Closed
3 tasks done
RMacfarlane opened this issue Sep 30, 2019 · 1 comment
Closed
3 tasks done

Test selection decorations in the minimap #81689

RMacfarlane opened this issue Sep 30, 2019 · 1 comment
Labels
testplan-item
Milestone
September 2019

Comments

@RMacfarlane
Copy link
Contributor

RMacfarlane commented Sep 30, 2019 •
edited by mjbvz
Loading

Refs: #21404

Complexity: 2

The current editor text selection is now rendered as decorations in the minimap. The minimap.selectionHighlight theme color can be used to change the color of these decorations. Some things to test:

  • Multi-selection
  • Interactions with decorations from search
  • Different themes
  • Changing the minimap.selectionHighlight color
@RMacfarlane RMacfarlane added this to the September 2019 milestone Sep 30, 2019
@sandy081 sandy081 assigned mjbvz and unassigned bpasero Oct 1, 2019
This was referenced Oct 1, 2019
Closed
Closed
@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

This works great, nice work.

@isidorn isidorn removed their assignment Oct 1, 2019
@alexdima alexdima removed their assignment Oct 1, 2019
@mjbvz mjbvz removed their assignment Oct 1, 2019
@mjbvz mjbvz closed this as completed Oct 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
testplan-item
Projects
None yet
Milestone
September 2019
Development

No branches or pull requests
5 participants
@bpasero @isidorn @RMacfarlane @alexdima @mjbvz