Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High contrast: minimap selection color does not match editor selection color #81728

Closed
isidorn opened this issue Oct 1, 2019 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Oct 1, 2019

Refs: #81689

Every theme the selection color matches in the editor and in the minimap. However in the High Contrast theme that is not the case.
I do not understand the incosistency here and I would suggest that we use the same white color as in the editor.
I like how the current solution wokrs so I can be conviced that we should go with that one, I just do not like the inconsistency.

fyi @misolori

Screenshot 2019-10-01 at 12 07 30

@isidorn
Copy link
Contributor Author

isidorn commented Oct 1, 2019

Another downside of this approach is that the search decoration are not that visible (orange on yellow)

@RMacfarlane
Copy link
Contributor

Nice catch, I didn't notice this before. High contrast mode seems to use some other color than editor.selectionBackground as the editor color here. I'll update to match that color 👍

@isidorn
Copy link
Contributor Author

isidorn commented Oct 2, 2019

Adding bug and milestone so we verify this. Thanks for fixing.

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Oct 2, 2019
@isidorn isidorn added this to the September 2019 milestone Oct 2, 2019
@isidorn isidorn added the verified Verification succeeded label Oct 2, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants