Git on network drive broken after upgrade to 1.44.0

[limenet]

• VSCode Version: 1.44.0
• OS Version: Windows 10.0.18363

Steps to Reproduce:

1. Upgrade to 1.44.0
2. Open a project located on a network drive (e.g. Z:\project-name which points to \\code.swift\code\project-name)
3. Modify a file, e.g. .npmrc
4. Switch to Source Control
5. Observe
   1. The file cannot be added/diffed etc.
   2. The filename shown contains the network drive letter and/or the project name

When using the latest Insider (from Apr 09) with no extensions, the behavior is similar but slightly different:

1. The file can be added/diffed
2. The file cannot be unstaged

It appears that the first backslash in the path (after Z:) is discarded as is the project-name portion.

As implied by the title, the issue only occurs for the network drive projects and not for local projects on drive C:\. In those cases, the Git integration works like it did in 1.43.x and there is no smaller and greyed-out path portion visible next to the filename either.

Does this issue occur when all extensions are disabled?: Yes

Please let me know if you need any further information and Happy Easter!

Screenshots

(all taken using the same file)

1.44.0

Insider

Git Log:

> git ls-files --stage -- z:project-name\.npmrc
fatal: z:project-name\.npmrc: 'z:project-name\.npmrc' is outside repository at '//code.swift/code/project-name'
> git ls-files --stage -- z:project-name\.npmrc
> git branch
fatal: z:project-name\.npmrc: 'z:project-name\.npmrc' is outside repository at '//code.swift/code/project-name'
> git reset -q HEAD -- z:project-name\.npmrc
fatal: z:project-name\.npmrc: 'z:project-name\.npmrc' is outside repository at '//code.swift/code/project-name'
> git ls-files --stage -- z:project-name\.npmrc
fatal: z:project-name\.npmrc: 'z:project-name\.npmrc' is outside repository at '//code.swift/code/project-name'
> git ls-files --stage -- z:project-name\.npmrc
fatal: z:project-name\.npmrc: 'z:project-name\.npmrc' is outside repository at '//code.swift/code/project-name'

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Keyboard layout change does apply to key shortcuts (#42153)
• Command + Z Not Working (#91611)
• Git tab doesn't handle multiple workspaces with the same git submodules (#75443)

[eamodio]

@limenet I can't seem to reproduce this myself, but I could simulate the behavior you were seeing if there was a rogue trailing backslash -- so I've made a change that should hopefully resolve it. Can you please try out Monday's insiders build and see if the issue is resolved for you? Thanks!

[limenet]

@eamodio thank you for your quick fix!

Now the error messages don't appear anymore and it mostly works but vscode (Insider build from this morning) appears to be confused about the file location:

1. Open Insider
2. Drag & drop the project on the network drive (same as in the initial report)
3. Modify text file .npmrc

Git detects the change but lists the file under its full path and when clicking the "open file" icon it also opens it at the full path instead of the relative path respective to the workspace root:

The first tab is from when I opened the file from the workspace, the second one from "open file" in the Git sidebar. Both tabs refer to the same file although the first (workspace) tab uses the drive letter Z:\ and the second uses the network path \\code.swift\....

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@limenet, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version c8826e4 of Insiders (today's or later - you can use Help: About in the command pallette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[limenet]

/verified

Thank you very much, @eamodio !

[eamodio]

@limenet is the issue you mentioned here: #94882 (comment) gone now too?

[limenet]

@eamodio yes, that issue is now gone as well!

[eamodio]

Awesome, thanks!

[eamodio]

Verify steps:

• Open a project located on a network drive (e.g. Z:\project-name which points to \code.swift\code\project-name)
• Modify a file, e.g. .npmrc
• Switch to Source Control
• Observe
  • The file can be added/diffed etc.
  • The filename shown contains a relative path (not a wrong absolute path)

[sbatten]

Needed to update to git version 2.26.1.windows.1, I was on 2.25.x

[klaasnicolaas]

No idea if it is allowed to respond to a closed issue.

I have the same problems (can no longer make or stash commits) and use version 1.44.2 of VScode and Git version 2.26.2. Only when I downgraded Git to 2.24.x, I got no more errors with "is outside repository at ...".