Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore snippets (from IntelliSense) #109916

Merged
merged 4 commits into from
Nov 4, 2020
Merged

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Nov 3, 2020

This PR fixes #10565

Add the ability to ignore snippets so that they don't appear in IntelliSense or tab completions. Tho, they can still be inserted via "Insert Snippet" and that's also the place at which ignoring is configure.

The following gif shows how the dowhile TypeScript snippet is being ignored

Nov-03-2020 16-29-21

@jrieken jrieken self-assigned this Nov 3, 2020
@jrieken jrieken added this to the November 2020 milestone Nov 3, 2020
@jrieken
Copy link
Member Author

jrieken commented Nov 3, 2020

@misolori can you consult me with those icons? Ended up using the eye and eye-closed to express "disabled in intellisense"

@jrieken jrieken merged commit b449c95 into master Nov 4, 2020
@jrieken jrieken deleted the joh/snippetIgnore branch November 4, 2020 09:04
@miguelsolorio
Copy link
Contributor

@jrieken I know you already merged this, but I'd probably have the icon show the action it's going to perform (like a video player pause/resume buttons). So reverse the state of the icon and show the slashed eye for the action to disable the snippet.

@jrieken
Copy link
Member Author

jrieken commented Nov 4, 2020

Roger... It's always so confusing what state to use: the current or future one...

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[snippets] Cannot override/disable snippets defined in extensions
2 participants