Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isidorn/extensions statusbar #1123

Merged
merged 13 commits into from
Dec 9, 2015
Merged

Isidorn/extensions statusbar #1123

merged 13 commits into from
Dec 9, 2015

Conversation

isidorn
Copy link
Contributor

@isidorn isidorn commented Dec 9, 2015

Merge in the extensions status bar to get feedback
@stevencl I will merge what I showed yesterday about the status bar. We try it out for a few days and if we are against it I will remove it.

isidorn added a commit that referenced this pull request Dec 9, 2015
@isidorn isidorn merged commit 960258c into master Dec 9, 2015
@isidorn isidorn deleted the isidorn/extensions-statusbar branch December 9, 2015 09:20
@stevencl
Copy link
Member

stevencl commented Dec 9, 2015

I understand the motivation for this and I am aware that this is a stopgap solution due to the fact that we do not have a richer notification UX.

As a stopgap though, I think I would prefer that we have a command in the View menu, 'Show extension warnings and errors' that is off by default. The issue with having an icon in the status bar that when clicked shows the extension commands is that it doesn't provide all that much value to begin with. Then, when there are errors, the changes in colour may be more likely to be missed, as many users may not have been paying that much attention to the icon in the status bar.

Another stopgap solution would be to add another label next to the icon whenever there are errors which shows the number of errors. If that is clicked then we show the extension errors immediately rather than just showing the extension commands.

More importantly though, this highlights the need for a rich notification UX in the product. We have started littering the status bar with notifications like these, all of which when clicked present some info at the top of the screen (in the command palette/quick open). The distance between the status bar and quick open is sufficiently large for these affordances to feel disconnected. While it helps reduce the number of different UX affordances we have in the product (a good thing) I think it requires too much travel with the mouse and doesn't support a holistic view of all of the notifications and warnings that the user needs to pay attention to.

Ideally we require a much richer notification UX for the whole product. This is something we need to work on and is on our UX backlog.

@isidorn
Copy link
Contributor Author

isidorn commented Dec 9, 2015

@stevencl all your points make sense
@egamma @chrisdias should decide if the current solution is a good enough for temporary or we even do not want that.

@egamma
Copy link
Member

egamma commented Dec 9, 2015

@stevencl makes good points.

We need a way to show a user conflicts in the extensions. This is a pain point we have to address now and we need to deliver a minimal tactical solution for this.

Another stopgap solution would be to add another label next to the icon whenever there are errors which shows the number of errors. If that is clicked then we show the extension errors immediately rather than just showing the extension commands.

This works for me.

@isidorn
Copy link
Contributor Author

isidorn commented Dec 9, 2015

So we agreed on the following:

  • if there are no warning or errors - do not show anything in the status bar
  • if there are - show the number next to the icon
  • leave everything colorless to fit better with the other status bar items
  • ask @bgashler1 for a nice icon (sent email)
  • on click show all the errors and warnings via message service

We also want to provide an 'Uninstall extension' actino which would give the user an option to get out of the error state.

As for the future we want to look into adding more color to the status bar.

@stevencl
Copy link
Member

stevencl commented Dec 9, 2015

Sounds good

isidorn added a commit that referenced this pull request Dec 11, 2015
@isidorn
Copy link
Contributor Author

isidorn commented Dec 11, 2015

Ok I have incorporated your feedback,
I am temporarily using an old monaco icon, will incorporate a new one once @bgashler1 provides one.

I still have to look into adding an uninstall action.
To see the new status bar, just create an extension conflict in your extensions folder, e.g duplicate an extension and in the duplicated extension change the publisher.

screen shot 2015-12-11 at 11 20 31

@egamma egamma mentioned this pull request Dec 11, 2015
18 tasks
isidorn added a commit that referenced this pull request Dec 14, 2015
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants