Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp methods for targeting arm systems #12486

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

ted-piotrowski
Copy link
Contributor

prepareDebPackage/buildDepPackage are passed the architecture string "armhf". They use this string to index into an object inside

function getDebPackageArch(arch) {
    return { x64: 'amd64', ia32: 'i386', arm: 'armhf' }[arch];
}

However, the object key is "arm" not "armhf", causing the function to return 'undefined' which results in a broken package. Same applies for the Rpm equivalent.

Bug was introduced in the original change:
007c2ca

@msftclas
Copy link

Hi @ted-piotrowski, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.19% when pulling 98c1902 on ted-piotrowski:master into 7baf009 on Microsoft:master.

@Tyriar Tyriar self-assigned this Sep 22, 2016
@Tyriar Tyriar added this to the September 2016 milestone Sep 22, 2016
@Tyriar Tyriar merged commit 63a5ab8 into microsoft:master Sep 22, 2016
@Tyriar
Copy link
Member

Tyriar commented Sep 22, 2016

👍 thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants