-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle extension resources on server #141572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just left a couple of suggestions.
What’s the rationale for this feature? It seems to create a completely open reverse proxy to any domain on the internet (and worse, the private networks that the server has access to). The browser handles cross origin request in a separate security context (which is what you want), this feature will effectively disable these safeguards. |
@monken Thanks for your feedback and very much appreciated. This is not targeting any server/domain in the internet. This is to redirect requests to the service (we are hosting) from the client to the server. We have strict CORS rules on this service of ours and its blocking the dev set up and testing. Instead of loosening the CORS rules (which is not ideal) we are redirecting these specific requests through server. Hope it is clear. |
- Set selective request and response headers - Update the scheme on the client
Handle extension resources on server