-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language filter initial draft #145080
Language filter initial draft #145080
Conversation
src/vs/workbench/contrib/preferences/browser/settingsEditor2.ts
Outdated
Show resolved
Hide resolved
It would be helpful if I could get suggestions for language IDs after typing Also, if I use a language ID that doesn't exist, I still get results, and can't tell that anything is wrong. |
I have one setting in a [html] block. When I enter |
We add a link for language filters in complex renderers, so that for settings such as [css], users can click on the setting link to be redirected to the language filter view. In the language filter view, we show all language overridable settings. In turn, the language filter acts more like a scope filter rather than a modified/configured settings filter. When a user edits a setting in that view, the edit applies to the given scope (tab) that the user is in, as well as the language they are currently filtering by.
With this change, we explicitly make it so that only the first language filter given is used.
f1f84b8
to
7d6f6f7
Compare
There were a few bugs with deciding what to render when that I fixed above. |
Fixed another bug with the |
Ref #131707
Summary
This PR adds an initial draft of the language filter:
@lang:
is suggested in the search widget@lang:langId
shows all language-overridable settings, but the values shown correspond to either the default setting value, or the language-specific setting value. TODO: determine whether we are showing/can show the language-specific overridden default value whenever it shows up.Demo