-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to specify language id in command to create a new untitled file #153872
Conversation
Looks good to me from editor service, i.e. when I run this code it opens a Python file: editorService.openEditor({
resource: undefined,
options: {
override: undefined,
pinned: true
},
languageId: 'python',
}); |
Ah, actually for some reason the builder was not compiling my changes incrementally, which is why I got the impression it's not working. Does it not watch for changes by default? I can confirm it works as well. I'll test out if walkthrough works as expected. |
It should but depends how you build. I just use |
Can confirm it works from welcome view 👍
I see, I used the default build command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit
@@ -629,28 +629,31 @@ KeybindingsRegistry.registerCommandAndKeybindingRule({ | |||
{ | |||
isOptional: true, | |||
name: 'viewType', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set this name to be something meaningful now that it's not just view type
This PR fixes #152920
@bpasero @lramos15 Unfortunately this does not seem to be working even if I hardcode the language id as
"python"
, would be needing some help here.