Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to ESM #166033

Closed
wants to merge 330 commits into from
Closed

Switch to ESM #166033

wants to merge 330 commits into from

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Nov 10, 2022

re #160416

To run:

  • run node migrate.js
  • run yarn watch

To do:

  • run from source
    • main process
    • renderer window
    • extension host process
    • extension host web worker
    • editor worker
    • output link computer
    • issue reporter window
    • process explorer window
    • shared process window
    • shared process web worker (enables search and file watching)
  • run web from source
  • run server from source
  • run unit tests
    • node-based (mocha test/unit/node/index.mjs --delay --ui=tdd --timeout=5000 --exit --esm)
    • electron-based (./scripts/test.sh --esm)
    • browser-based (yarn test-browser --esm --browser chromium, only chromium because of importmap, likely needs an update of playwright)
  • run integration tests
    • browser-based (./scripts/test-web-integration.sh --esm)
    • electron-based (./scripts/test-integration.sh --esm)
    • remote
  • run smoke tests
  • bundling
    • ASAR
    • nls

@lemanschik

This comment was marked as off-topic.

@lemanschik

This comment was marked as off-topic.

@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Nov 22, 2022
@bpasero
Copy link
Member

bpasero commented Aug 15, 2024

The changes in this PR have been ported to main and we can now build with ESM from main using this build option:

image

Developing locally from main:

  • node migrate.mjs
  • yarn watch-esm
  • scripts/code.sh

Tests:

  • scripts/test-esm.sh
  • yarn test-browser-esm
  • yarn test-node-esm

@bpasero bpasero closed this Aug 15, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants