Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM - Add document property to expose the text document #171504

Merged
merged 13 commits into from
Apr 14, 2023
Merged

SCM - Add document property to expose the text document #171504

merged 13 commits into from
Apr 14, 2023

Conversation

lszomoru
Copy link
Member

@lszomoru lszomoru commented Jan 17, 2023 •
edited
Loading

This pull requests add proposed api to expose a new, document property to get access to the TextDocument of the scm input.

@lszomoru lszomoru added the scm General SCM compound issues label Jan 17, 2023
@lszomoru lszomoru added this to the January 2023 milestone Jan 17, 2023
@lszomoru lszomoru self-assigned this Jan 17, 2023
@gjsjohnmurray
Copy link
Contributor

Is this going to become proposed API?

@lszomoru
Copy link
Member Author

@gjsjohnmurray, yes, the idea is to add this first as proposed API.

@lszomoru lszomoru modified the milestones: January 2023, February 2023 Jan 19, 2023
@jrieken jrieken modified the milestones: February 2023, March 2023 Feb 23, 2023
@kieferrm kieferrm mentioned this pull request Mar 6, 2023
Closed
91 tasks
@lszomoru lszomoru modified the milestones: March 2023, April 2023 Mar 20, 2023
@kieferrm kieferrm mentioned this pull request Apr 2, 2023
Closed
90 tasks
@lszomoru lszomoru requested a review from jrieken April 3, 2023 13:13
@lszomoru lszomoru marked this pull request as ready for review April 3, 2023 13:15
jrieken
jrieken previously approved these changes Apr 4, 2023
View reviewed changes
src/vs/workbench/api/common/extHostSCM.ts Outdated Show resolved Hide resolved
jrieken
jrieken previously approved these changes Apr 5, 2023
View reviewed changes
joaomoreno
joaomoreno previously approved these changes Apr 5, 2023
View reviewed changes
@lszomoru lszomoru dismissed stale reviews from joaomoreno and jrieken via d874b12 April 14, 2023 07:48
@lszomoru lszomoru merged commit 218b8bd into main Apr 14, 2023
@lszomoru lszomoru deleted the lszomoru/scm-input-document-api branch April 14, 2023 11:55
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

@joaomoreno joaomoreno joaomoreno left review comments

Assignees

@lszomoru lszomoru

Labels
scm General SCM compound issues
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@lszomoru @gjsjohnmurray @joaomoreno @jrieken