Finalize onWillSaveNotebookDocument #179188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
force-pushed
the
rebornix/competent-reptile
branch
from
155af2b
to
e08b258
Compare
connor4312
reviewed
Apr 4, 2023
| waitUntil(thenable: Thenable<WorkspaceEdit>): void; | ||
|
|
||
| /** | ||
| * Allows to pause the event loop until the provided thenable resolved. |
There was a problem hiding this comment.
This wording is kind of awkward. "Allows pausing" instead of "Allows to pause" would be better. Also, it doesn't pause the (JavaScript) event loop, it just pauses the process of saving the file. But I see we have the same wording for the equivalent text document event too, so maybe we should put in a new PR to update both.
connor4312
approved these changes
Apr 4, 2023
TylerLeonhardt
approved these changes
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.