Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of A11yService & go back to aria-activedescendant #179217

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Apr 4, 2023

Follow up of #179193

Sorry for the confusion... but where this ends up is:

  • we still use aria-activedescendant
  • we set the aria-label of the list to be the placeholder/saneAriaLabel value

This is based on the idea from #176081 (comment)

@TylerLeonhardt TylerLeonhardt self-assigned this Apr 4, 2023
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) April 4, 2023 23:48
@VSCodeTriageBot VSCodeTriageBot added this to the April 2023 milestone Apr 4, 2023
@TylerLeonhardt TylerLeonhardt changed the title Use alert instead of aria-live and remove usage of A11yService Remove usage of A11yService & go back to aria-activedescendant Apr 5, 2023
@TylerLeonhardt TylerLeonhardt merged commit 40662a9 into main Apr 5, 2023
@TylerLeonhardt TylerLeonhardt deleted the tyler/promising-rhinoceros branch April 5, 2023 02:11
@github-actions github-actions bot locked and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants