Initial IssueUriRequestHandler proposed API #180363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lramos15
reviewed
Apr 19, 2023
| hide(descriptionTextArea); | ||
| reset(descriptionTitle, localize('handlesIssuesElsewhere', "This extension handles issues outside of VS Code")); | ||
| reset(descriptionSubtitle, localize('elsewhereDescription', "The '{0}' extension prefers to use an external issue reporter. To be taken to that issue reporting experience, click the button below.", selectedExtension.displayName)); | ||
| this.previewButton.label = localize('openIssueReporter', "Open Issue Reporter"); |
There was a problem hiding this comment.
I feel like we should have this say External or something that makes it clear this isn't the issue reporter that you're currently in for those who don't read the description
There was a problem hiding this comment.
Yeah makes sense. I'll do that in a follow up PR
lramos15
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #46726