TS extension: register call to CopilotRelated with copilot extension #228610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registerRelatedFilesProvider is a new method on the copilot extension. CopilotRelated is a new tsserver command that provides information from tsserver to copilot. (The information is not necessarily copilot-specific, of course.)
Thanksyou23
reviewed
Sep 14, 2024
mjbvz
reviewed
Sep 16, 2024
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
Outdated
Show resolved
Hide resolved
| callback: (uri: vscode.Uri) => Promise<{ entries: vscode.Uri[]; traits?: { name: string; value: string }[] }> | ||
| ): void; | ||
| } | undefined; | ||
| if (relatedAPI) { |
There was a problem hiding this comment.
Does this also need to be gated on the TS server version?
There was a problem hiding this comment.
I expect it to ship in 5.7. Gating it is a good idea. How do I do that? I saw a lot of // @ts-expect-error until ts 5.6 in the code base, accompanied by if (event.body.entries) kinds of checks. Is that the right way?
There was a problem hiding this comment.
Ah, the language features are gated on API.v560 (for example). Is it OK to add API.v570?
extensions/typescript-language-features/src/typeScriptServiceClientHost.ts
Outdated
Show resolved
Hide resolved
It is now in its own file. Also address other PR comments.
mjbvz
reviewed
Sep 20, 2024
extensions/typescript-language-features/src/languageFeatures/copilotRelated.ts
Outdated
Show resolved
Hide resolved
extensions/typescript-language-features/src/languageFeatures/copilotRelated.ts
Outdated
Show resolved
Hide resolved
The select provided at registration contains the correct list of languages to register for the provider.
|
My latest commit now has the API that we intend to use in the short- and medium-term. |
mjbvz
approved these changes
Oct 4, 2024
connor4312
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerRelatedFilesProvider is a new method on the copilot extension. CopilotRelated is a new tsserver command that provides information from tsserver to copilot. (The information is not necessarily copilot-specific, of course.)
Depends on microsoft/TypeScript#59963 to be available -- the typescript protocol doesn't include CopilotRelated yet.
Needs a follow-up to update the copilot API: