JavaScript: Enable ES6 by Default

[felixrieseberg]

• This tiny commit enables ES6 support for JavaScript files by default, ensuring that VS Code supports popular JavaScript frameworks and modules out of the box.
• Tests pass, behaviour otherwise unchanged.

Closes #318
🚢 @joaomoreno @poteto @wycats

[msftclas]

Hi @felixrieseberg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Felix Rieseberg). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

[joaomoreno]

Damn gotta fix that build. @jrieken is the guy to review this.

[jrieken]

As much as I would like this change to be merged and as correct as it will, I still have to reject. An attempt to explain:

Our current JavaScript implementation is based on a slightly out-dated version of TypeScript and a lot of code I am not so proud of - we basically rewrite JavaScript to TypeScript. It was the right thing to do back when we started but in the mean time TypeScript catches up and very soon we will replace our custom JavaScript language service with the TypeScript solution. And as long as TypeScript sets the default to ES5 we shouldn't do anything different. Changing the default and then, by using TypeScript, changing it back won't get applause.

Tho having said that. This is where TypeScript sets the default ;-)

[felixrieseberg]

@jrieken: Thanks for the explanation. I'm not married to any particular implementation, but I'm worried that having to create solution files for simple JavaScript doesn't exactly advertise Code as a great JavaScript editor.

Are you opposed to the user scenario of editing ES6 without further configuration? Since the issue is closed too, it seems like you'd rather have people use another editor. Leaving it open, even if the issue is upstream, would at least signal that we're aware that having to read documentation just to edit a simple *.js file with a let in it is a bad user experience.

[jrieken]

@felixrieseberg Closing for now means we will reopen as soon as we have the chance to do provide a long term fix.

[poteto]

I agree with @felixrieseberg, closing the issue (#318, not the PR) sends a signal to other people with less context that Code will never support ES6 by default.

[felixfbecker]

I think a jsconfig.json is just so weird. Why compilerOptions when I'm not compiling anything (already said this in #408). VS Code should have first class support for (modern) JS. If the internal implementation is ugly, at least set it to ES6 until it's improved.

[admmasters]

Also agree that ES6 should be default.

[arlair]

ES6 should be the default. I normally can't be bothered creating a file to get syntax highlighting and close VS Code and go use a different editor.

[zbandhan]

Definitely ES6 should be the default in my opinion

[msftclas]

Hi @felixrieseberg, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

It looks like you're a Microsoft contributor (Felix Rieseberg). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

[jrieken]

Discussed with with TS team and they will make sure Latest becomes the default when project salsa is real (microsoft/TypeScript#6017, microsoft/TypeScript#4789)

[jrieken]

@felixrieseberg I know it has been a while and there been discussion but I wonder if you willing to continue the work? Simply rebase with master and instead of ES6 we want to use Latest?

[felixrieseberg]

Thanks, I'm very happy about this - I'll rebase and update. Should be in in about three hours (once I'm back in front of a notebook). Thanks a lot 🚀!

[jrieken]

Thanks. No hurries. End of week is good for me.

[joaomoreno]

❤️

[felixrieseberg]

@jrieken: This should now be good to go 🍻

[jrieken]

Cheers 🍻

[SteveALee]

Nice! Thanks all