enable dynamic menu on linux/windows #59936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workaround to fix microsoft#33457
sbatten
added
linux
bpasero
approved these changes
Oct 4, 2018
| @@ -36,6 +36,9 @@ export class Menubar { | |||
| private closedLastWindow: boolean; | |||
|
|
|||
| private menuUpdater: RunOnceScheduler; | |||
| private menuGC: RunOnceScheduler; | |||
|
|
|||
| private oldMenus: Menu[]; | |||
There was a problem hiding this comment.
@sbatten this needs a comment at least why we are doing it with a reference to the electron issue and a TODO to remove this when Electron fixed it!
| @@ -56,6 +59,8 @@ export class Menubar { | |||
| ) { | |||
| this.menuUpdater = new RunOnceScheduler(() => this.doUpdateMenu(), 0); | |||
|
|
|||
| this.menuGC = new RunOnceScheduler(() => { this.oldMenus = this.oldMenus.slice(this.oldMenus.length - 1); }, 10000); | |||
There was a problem hiding this comment.
@sbatten I am not sure it helps to always keep the last menu around, I would probably empty the entire array after 10 seconds. Reason is that the user might be lucky to open the menu very early, then we got 2-3 updates and so the last menu in this array will not be the one the user had opened anyways.
| @@ -203,6 +210,11 @@ export class Menubar { | |||
|
|
|||
| private install(): void { | |||
|
|
|||
| const oldMenu = Menu.getApplicationMenu(); | |||
There was a problem hiding this comment.
@sbatten again, comment to explain why
38 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workaround to fix #55347