Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new tree in Problems panel #59976

Merged
merged 37 commits into from
Oct 12, 2018
Merged

Adopt new tree in Problems panel #59976

merged 37 commits into from
Oct 12, 2018

Conversation

joaomoreno
Copy link
Member

@joaomoreno joaomoreno commented Oct 4, 2018

  • Extract CodeActions related code out of the model
  • Remove filtering from the model
  • Slim down model to its essence
  • Replace tree with ObjectTree
  • Add filtering back
  • Implement collapse all
  • Add context menus back
  • Cleanup console.warn calls
  • Type in tree and focus the input field

cc @sandy081 will ask you for review later in the milestone 👍

@joaomoreno joaomoreno added feature-request Request for new features or functionality error-list Problems view labels Oct 4, 2018
@joaomoreno joaomoreno added this to the October 2018 milestone Oct 4, 2018
@joaomoreno joaomoreno self-assigned this Oct 4, 2018
@joaomoreno
Copy link
Member Author

Got mouse and keyboard navigation working in a very dirty way after 2 days. Now just found out that context menu actions are globally registered commands and everything works through context key service... this is a nightmare.

@joaomoreno
Copy link
Member Author

OK easier than expected, getting closer.

@joaomoreno
Copy link
Member Author

joaomoreno commented Oct 11, 2018

@sandy081 This is READY for a good smoketest by you and to be merged to master. There WILL be bugs. 🐛

The only missing piece is the accessibility provider, which the list doesn't yet support, but should be easy to get in.

@joaomoreno
Copy link
Member Author

Bug:

  1. reload workbench with text in the filter box, filtering every single result out
  2. type more text into the filter box
  3. clear filter

tree doesn't appear!

@joaomoreno joaomoreno merged commit ee0a369 into master Oct 12, 2018
@sandy081
Copy link
Member

Good Job @joaomoreno

@joaomoreno joaomoreno deleted the joao/markers-tree branch October 15, 2018 18:04
@joaomoreno joaomoreno mentioned this pull request Oct 29, 2018
3 tasks
@joaomoreno joaomoreno mentioned this pull request Nov 6, 2018
38 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
error-list Problems view feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants